chore: update tests to use new SendPacket API (backport #2567) #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* chore: update tests to use new SendPacket API * add changelog * remove source port and source channel from parameter list of SendPacket Co-authored-by: Carlos Rodriguez <[email protected]> (cherry picked from commit 8ce603d) # Conflicts: # modules/core/ante/ante_test.go # modules/light-clients/07-tendermint/client_state_test.go
mergify
bot
requested review from
AdityaSripal,
seantking,
charleenfei,
colin-axner and
damiannolan
as code owners
|
Backport hell! I will fix the tests tomorrow... |
added 8 commits
October 27, 2022 12:04
damiannolan
approved these changes
Oct 31, 2022
colin-axner
reviewed
Nov 1, 2022
modules/core/ante/ante_test.go
Outdated
|
|
||
| err := suite.path.EndpointA.SendPacket(packet) | ||
| suite.Require().NoError(err) | ||
| clienttypes.NewHeight(2, 0), 0) |
There was a problem hiding this comment.
was this supposed to change?
There was a problem hiding this comment.
Good catch. It was not intentional, but I copied from main. I will change it back
modules/core/ante/ante_test.go
Outdated
| func (suite *AnteTestSuite) createRecvPacketMessage(sequenceNumber uint64, isRedundant bool) sdk.Msg { | ||
| packet := channeltypes.NewPacket(ibctesting.MockPacketData, sequenceNumber, | ||
| func (suite *AnteTestSuite) createRecvPacketMessage(isRedundant bool) sdk.Msg { | ||
| sequence, err := suite.path.EndpointA.SendPacket(clienttypes.NewHeight(2, 0), 0, ibctesting.MockPacketData) |
colin-axner
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2567 done by Mergify.
Cherry-pick of 8ce603d has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com