Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump icad tag with ibc-go v5.0.0 + gofumpt #2461

Merged
merged 4 commits into from
Oct 5, 2022

Conversation

crodriguezvega
Copy link
Contributor

Description

  • Bumps the icad tag to the one created by @damiannolan using ibc-go v5.0.0.
  • Changes resulted of running gofumpt.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for updating these! 🙏

Seems like 23-commitment/types/merkle.go is complaining about gofumpt 🤨

@crodriguezvega
Copy link
Contributor Author

Nice! Thanks for updating these! 🙏

Seems like 23-commitment/types/merkle.go is complaining about gofumpt 🤨

Yeah, I am trying to see if I can fix it...

@crodriguezvega crodriguezvega merged commit 8c7c655 into main Oct 5, 2022
@crodriguezvega crodriguezvega deleted the carlos/gofumpt-and-use-latest-ica-tag branch October 5, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants