Renamed icatypes.PortPrefix to icatypes.ControllerPortPrefix #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es.PortID to icatypes.HostPortID
alizahidraja
requested review from
AdityaSripal,
seantking,
charleenfei,
colin-axner and
damiannolan
as code owners
alizahidraja
requested review from
crodriguezvega and
chatton
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2450 +/- ##
=======================================
Coverage 78.64% 78.64%
=======================================
Files 178 178
Lines 12365 12365
=======================================
Hits 9725 9725
Misses 2208 2208
Partials 432 432
|
crodriguezvega
approved these changes
Oct 3, 2022
colin-axner
approved these changes
Oct 3, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
* renamed icatypes.PortPrefix to icatypes.ControllerPortPrefix & icatypes.PortID to icatypes.HostPortID * updated changelog.md * updated changelog.md (cherry picked from commit 2056c2d)
colin-axner
pushed a commit
that referenced
this pull request
Oct 4, 2022
…2459) * renamed icatypes.PortPrefix to icatypes.ControllerPortPrefix & icatypes.PortID to icatypes.HostPortID * updated changelog.md * updated changelog.md (cherry picked from commit 2056c2d) Co-authored-by: Ali Zahid Raja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renamed icatypes.PortPrefix to icatypes.ControllerPortPrefix & icatypes.PortID to icatypes.HostPortID
closes: #2433
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/) (not applicable)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes