Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs deployment #2432

Merged
merged 10 commits into from
Sep 29, 2022
Merged

Fix docs deployment #2432

merged 10 commits into from
Sep 29, 2022

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Sep 29, 2022

Description

This PR syncs the Makefile target with the one in the cosmos-sdk repo, removes additional uneeded dependencies, and adds the option to trigger a docs deployment through the UI (via workflow_dispatch)

The docs built from this PR are live here 🥳


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye! Marvelous!! 💛

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@chatton chatton merged commit 7408d52 into main Sep 29, 2022
@chatton chatton deleted the cian/fix-ci-docs-deploy branch September 29, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants