Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.0 post release chores #2428

Merged
merged 9 commits into from
Sep 30, 2022
Merged

v5.0.0 post release chores #2428

merged 9 commits into from
Sep 30, 2022

Conversation

crodriguezvega
Copy link
Contributor

@crodriguezvega crodriguezvega commented Sep 28, 2022

Description

I added also backport tasks for v2.5.x, v3.4.x, v4.2.x and 5.1.x and removed the backport taks for discontinued releases.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make adding v5 to compatibility tests a post release chore?

RELEASES.md Show resolved Hide resolved
@crodriguezvega
Copy link
Contributor Author

Should we make adding v5 to compatibility tests a post release chore?

Yeah, good idea! @chatton, can you please check if the changes look ok to you?

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing these followups @crodriguezvega !

We need to make some changes though for the test matricies, we want to still be able to run them from the release-v5 branch. So rather than updating the existing set, we can create a new set for v6 (make sure the name of the files align as this is important for reading the correct file)

We can have two entries for the workflow now

release-v5.0.x and release-v6.0.x

The new v6 file can run tests against v5.0.0 as well as the previous versions.

All the other changes look good!

@chatton
Copy link
Contributor

chatton commented Sep 30, 2022

@crodriguezvega it might be worth triggering the v6 test suite before you merge to main. You can do this in the UI via

Actions -> Compatibility E2E -> Run Workflow (choose your branch, not main) -> select release-v6.0.x

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @crodriguezvega

@crodriguezvega crodriguezvega merged commit 9fdcf2c into main Sep 30, 2022
@crodriguezvega crodriguezvega deleted the carlos/post-release-chores branch September 30, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants