Fix docs rendering issue #2421
Merged
Fix docs rendering issue #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
commented
Sep 28, 2022
| "node-forge": "^1.3.1", | ||
| "nth-check": "^2.1.1", | ||
| "url-parse": "^1.5.10", | ||
| "vue": "^2.6.14", | ||
| "vuepress-theme-cosmos": "^1.0.183" |
There was a problem hiding this comment.
@colin-axner do you have some more context about these packages? I don't think we need any of these as direct dependencies.
There was a problem hiding this comment.
Unfortunately no, these additions were the result of trying to bump the versions for these packages as they were causing "security vulnerability" notifications (nothing that affects our code, just docs - and even then I'm not sure there is anything exploitable)
I believe we get these dependencies indirectly from vuepress-cosmos-theme
There was a problem hiding this comment.
insert node modules heaviest matter in the universe meme
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
seantking,
charleenfei and
damiannolan
as code owners
colin-axner
approved these changes
Sep 28, 2022
crodriguezvega
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The docs were not rendering correctly, it looks like they stopped rendering after this commit however they still successfully built.
To test, checkout this branch
rm -rf docs/node_modules make view-docs # navigate to localhost:8080closes: #2420
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes