Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating 09-localhost migration code to v7 #2392

Merged
merged 3 commits into from
Sep 28, 2022

Conversation

damiannolan
Copy link
Member

Description

  • Updating future migration code to use correct package versioning

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@damiannolan damiannolan marked this pull request as ready for review September 26, 2022 14:53
@codecov-commenter
Copy link

Codecov Report

Merging #2392 (11627f6) into main (875279d) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2392   +/-   ##
=======================================
  Coverage   79.56%   79.56%           
=======================================
  Files         175      175           
  Lines       12134    12134           
=======================================
  Hits         9655     9655           
  Misses       2050     2050           
  Partials      429      429           
Impacted Files Coverage Δ
modules/core/migrations/v7/migrations.go 88.23% <100.00%> (ø)

@damiannolan damiannolan enabled auto-merge (squash) September 28, 2022 10:52
@damiannolan damiannolan merged commit 09788ec into main Sep 28, 2022
@damiannolan damiannolan deleted the damian/update-localhost-migrations branch September 28, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants