chore: update godocs for legacy apis on controller module #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleenfei
requested review from
seantking,
colin-axner,
AdityaSripal and
damiannolan
as code owners
charleenfei
requested review from
crodriguezvega and
chatton
as code owners
chatton
approved these changes
Sep 23, 2022
damiannolan
approved these changes
Sep 26, 2022
Comment on lines
20
to
22
| // NOTE: this is a legacy API that is only intended to function correctly in workflows where an underlying application has been set | ||
| // Prior to to v6.x.x of ibc-go, the controller module was only functional as middleware, with authentication performed | ||
| // by the underlying authentication application. For a full summary of the changes in v6.x.x, please see ADR009. |
There was a problem hiding this comment.
nit
Suggested change
| // NOTE: this is a legacy API that is only intended to function correctly in workflows where an underlying application has been set | |
| // Prior to to v6.x.x of ibc-go, the controller module was only functional as middleware, with authentication performed | |
| // by the underlying authentication application. For a full summary of the changes in v6.x.x, please see ADR009. | |
| // NOTE: this is a legacy API that is only intended to function correctly in workflows where an underlying application has been set. | |
| // Prior to to v6.x.x of ibc-go, the controller module was only functional as middleware, with authentication performed | |
| // by the underlying application. For a full summary of the changes in v6.x.x, please see ADR009. |
Comment on lines
20
to
22
| // NOTE: this is a legacy API that is only intended to function correctly in workflows where an underlying application has been set | ||
| // Prior to to v6.x.x of ibc-go, the controller module was only functional as middleware, with authentication performed | ||
| // by the underlying authentication application. For a full summary of the changes in v6.x.x, please see ADR009. |
There was a problem hiding this comment.
same nit
Suggested change
| // NOTE: this is a legacy API that is only intended to function correctly in workflows where an underlying application has been set | |
| // Prior to to v6.x.x of ibc-go, the controller module was only functional as middleware, with authentication performed | |
| // by the underlying authentication application. For a full summary of the changes in v6.x.x, please see ADR009. | |
| // NOTE: this is a legacy API that is only intended to function correctly in workflows where an underlying application has been set. | |
| // Prior to to v6.x.x of ibc-go, the controller module was only functional as middleware, with authentication performed | |
| // by the underlying application. For a full summary of the changes in v6.x.x, please see ADR009. |
colin-axner
reviewed
Sep 26, 2022
modules/apps/27-interchain-accounts/controller/keeper/account.go
Outdated
Show resolved
Hide resolved
9 tasks
damiannolan
requested changes
Sep 30, 2022
There was a problem hiding this comment.
@charleenfei could you pull in the changes from #2448 here please? See #2448 (comment)
Thanks!
colin-axner
approved these changes
Oct 14, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 14, 2022
* update docs for legacy api (cherry picked from commit 95cec44) # Conflicts: # e2e/tests/transfer/base_test.go
damiannolan
pushed a commit
that referenced
this pull request
Oct 19, 2022
…2363) (#2547) * chore: update godocs for legacy apis on controller module (#2363) * update docs for legacy api (cherry picked from commit 95cec44) # Conflicts: # e2e/tests/transfer/base_test.go * delete e2e test Co-authored-by: Charly <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #2234
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes