Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: transfer memo tests #2306

Merged
merged 31 commits into from
Oct 26, 2022
Merged

e2e: transfer memo tests #2306

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
a9f4f40
added optional packet metadata to the packet and message types
nicolaslara Sep 19, 2022
2254b3d
added docs
nicolaslara Sep 19, 2022
ca6b1d1
packet metadata integration and tests
nicolaslara Sep 19, 2022
ed80695
Merge branch 'main' into nicolas/packet-metadata-proto
nicolaslara Oct 3, 2022
7c925b9
breaking the api (backports should add a utility function for this)
nicolaslara Oct 3, 2022
1448633
adding nil metadata on all the calls
nicolaslara Oct 3, 2022
71eae26
added metadata to the cli
nicolaslara Oct 3, 2022
2480e13
added events
nicolaslara Oct 3, 2022
f754572
Merge branch 'nicolas/packet-metadata-proto' into nicolas/packet-meta…
nicolaslara Oct 3, 2022
2ed648f
updated types to the api breaking versions
nicolaslara Oct 3, 2022
c43e5ad
added tests with metadata
nicolaslara Oct 3, 2022
bbd1d91
breaking api for FungibleTokenPacketData
nicolaslara Oct 5, 2022
9db4f98
hex encoding metadata
nicolaslara Oct 5, 2022
40709af
added abstraction
nicolaslara Oct 5, 2022
415cc40
Merge branch 'main' into nicolas/packet-metadata-proto
nicolaslara Oct 5, 2022
1497a4a
fixed bad merge
nicolaslara Oct 5, 2022
5faf1db
added tests with metadata
nicolaslara Oct 3, 2022
8eb9bc8
added missing metadata to packet for recv
nicolaslara Oct 5, 2022
389bb8a
Merge branch 'nicolas/packet-metadata-proto' into nicolas/packet-meta…
nicolaslara Oct 5, 2022
47df4c6
Merge branch 'main' of github.com:cosmos/ibc-go into nicolas/packet-m…
colin-axner Oct 26, 2022
f14fe9f
fix tests from merge conflict
colin-axner Oct 26, 2022
c466942
chore: update tests to use semver
colin-axner Oct 26, 2022
4737852
Merge branch 'main' of github.com:cosmos/ibc-go into nicolas/packet-m…
colin-axner Oct 26, 2022
4c2e228
chore: fix e2e tests
colin-axner Oct 26, 2022
40bdac4
Merge branch 'main' into nicolas/packet-metadata-integration-and-tests
colin-axner Oct 26, 2022
a6587eb
chore: revert unnecessary change
colin-axner Oct 26, 2022
915b68b
Merge branch 'nicolas/packet-metadata-integration-and-tests' of githu…
colin-axner Oct 26, 2022
85d6f20
chore: apply review suggestions
colin-axner Oct 26, 2022
c939043
fix: exit test upon unsupported chainA
colin-axner Oct 26, 2022
05fed7b
chore: apply review suggestions
colin-axner Oct 26, 2022
f22779b
Merge branch 'main' into nicolas/packet-metadata-integration-and-tests
colin-axner Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions e2e/tests/transfer/base_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,13 +418,15 @@ func (s *TransferTestSuite) TestMsgTransfer_WithMemo() {
s.Require().NoError(err)

if !memoFeatureRelease.IsSupported(chainAVersion) {
s.Require().Equal(transferTxResp.Code, uint32(2))
s.Require().Contains(transferTxResp.RawLog, "errUnknownField")
t.Logf("unsupported")
s.Require().Equal(uint32(2), transferTxResp.Code)
s.Require().Contains("errUnknownField", transferTxResp.RawLog)

// transfer not sent, end test
return
}

t.Logf("supported")
colin-axner marked this conversation as resolved.
Show resolved Hide resolved
// sender chain supports feature
s.AssertValidTxResponse(transferTxResp)

Expand All @@ -444,7 +446,7 @@ func (s *TransferTestSuite) TestMsgTransfer_WithMemo() {

chainBIBCToken := testsuite.GetIBCToken(chainADenom, channelA.Counterparty.PortID, channelA.Counterparty.ChannelID)

t.Run("packets relayed?", func(t *testing.T) {
t.Run("packets relayed", func(t *testing.T) {
s.AssertPacketRelayed(ctx, chainA, channelA.PortID, channelA.ChannelID, 1)

actualBalance, err := chainB.GetBalance(ctx, chainBAddress, chainBIBCToken.IBCDenom())
Expand Down