Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ica handshake reopening channel - use GetAppVersion in favour of channel.Version #2302

Merged
merged 9 commits into from
Sep 21, 2022
Merged

fix: ica handshake reopening channel - use GetAppVersion in favour of channel.Version #2302

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
871a799
adding unwrapping of channel version to ica controller handshake reop…
damiannolan Sep 19, 2022
5e9be5b
adding changelog
damiannolan Sep 19, 2022
6d6bdaf
adding ics4Wrapper to ics27 host submodule, handling unwrapping chann…
damiannolan Sep 19, 2022
c18da2c
updating changelog
damiannolan Sep 19, 2022
03c665b
Merge branch 'main' into damian/fix-reopening-channel-handshake
damiannolan Sep 20, 2022
59e0509
Merge branch 'main' into damian/fix-reopening-channel-handshake
colin-axner Sep 20, 2022
4c243e1
Merge branch 'main' into damian/fix-reopening-channel-handshake
damiannolan Sep 21, 2022
3559f5b
Merge branch 'main' into damian/fix-reopening-channel-handshake
Sep 21, 2022
7ac47d8
Merge branch 'main' into damian/fix-reopening-channel-handshake
damiannolan Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion modules/apps/27-interchain-accounts/controller/keeper/handshake.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,12 @@ func (k Keeper) OnChanOpenInit(
return "", sdkerrors.Wrapf(icatypes.ErrActiveChannelAlreadySet, "existing active channel %s for portID %s is already OPEN", activeChannelID, portID)
}

if !icatypes.IsPreviousMetadataEqual(channel.Version, metadata) {
appVersion, found := k.GetAppVersion(ctx, portID, activeChannelID)
if !found {
panic(fmt.Sprintf("active channel mapping set for %s, but channel does not exist in channel store", activeChannelID))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this panic introduces multiple conventions in the function (error return + panic) does it make more sense to return an error instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to panic?

Copy link
Member Author

@damiannolan damiannolan Sep 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned earlier in person I just followed essentially the same used above here - as in some places in ibc-go code we just panic because it's unreachable code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could add a comment indicating as such? The message we panic with seems like it would be a regular error that we could run into.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a nit: channel does not exist in channel store is kind of confusing if the error is GetAppVersion returning not found -- maybe something like channel version does not exist?

}

if !icatypes.IsPreviousMetadataEqual(appVersion, metadata) {
return "", sdkerrors.Wrap(icatypes.ErrInvalidVersion, "previous active channel metadata does not match provided version")
}
}
Expand Down