chore: adding msgServer struct to ics27 controller #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
requested review from
seantking,
colin-axner and
AdityaSripal
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2251 +/- ##
=======================================
Coverage 79.52% 79.52%
=======================================
Files 175 175
Lines 12067 12069 +2
=======================================
+ Hits 9596 9598 +2
Misses 2047 2047
Partials 424 424
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2022
(cherry picked from commit da1b7e0)
|
|
||
| // RegisterAccount defines a rpc handler for MsgRegisterAccount | ||
| func (k Keeper) RegisterAccount(goCtx context.Context, msg *types.MsgRegisterAccount) (*types.MsgRegisterAccountResponse, error) { | ||
| func (k msgServer) RegisterAccount(goCtx context.Context, msg *types.MsgRegisterAccount) (*types.MsgRegisterAccountResponse, error) { |
There was a problem hiding this comment.
Nit: should k be ms instead?
This was referenced Sep 9, 2022
colin-axner
pushed a commit
that referenced
this pull request
Sep 12, 2022
(cherry picked from commit da1b7e0) Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
msgServerstruct to ics27 controller submodulecloses: #2229
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes