Adding call to underlying app to OnChanCloseConfirm #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
commented
Sep 9, 2022
| @@ -115,7 +115,7 @@ func (im IBCMiddleware) OnChanOpenAck( | |||
| return nil | |||
| } | |||
|
|
|||
| // OnChanOpenAck implements the IBCMiddleware interface | |||
| // OnChanOpenConfirm implements the IBCMiddleware interface | |||
There was a problem hiding this comment.
not relevant but we had an incorrect docstring.
chatton
requested review from
seantking,
colin-axner,
AdityaSripal and
damiannolan
as code owners
crodriguezvega
approved these changes
Sep 9, 2022
…oseconfirm-in-controllersubmodule
chatton
deleted the
cian/issue#2237-call-underlying-app-onchancloseconfirm-in-controllersubmodule
branch
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2022
(cherry picked from commit fcdb0fc)
crodriguezvega
pushed a commit
that referenced
this pull request
Sep 11, 2022
…2256) (cherry picked from commit fcdb0fc) Co-authored-by: Cian Hatton <[email protected]>
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add call to underlying app in
OnChanCloseConfirmand adding relevant unit tests.closes: #2237
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes