Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR 009: ICS 27 simplication #2218

Merged
merged 5 commits into from
Sep 28, 2022
Merged

ADR 009: ICS 27 simplication #2218

merged 5 commits into from
Sep 28, 2022

Conversation

colin-axner
Copy link
Contributor

Description

Covers the changes proposed for ibc-go v6

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job, I think this covers everything without going too in-depth. I think pretty much all of my comments are nits.
Many thanks and much appreciated!

docs/architecture/adr-009-v6-ics27-msgserver.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-v6-ics27-msgserver.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-v6-ics27-msgserver.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-v6-ics27-msgserver.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-v6-ics27-msgserver.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-v6-ics27-msgserver.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-v6-ics27-msgserver.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-v6-ics27-msgserver.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-v6-ics27-msgserver.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-v6-ics27-msgserver.md Outdated Show resolved Hide resolved
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice write-up, @colin-axner!

docs/architecture/adr-009-v6-ics27-msgserver.md Outdated Show resolved Hide resolved

> Add a new `MsgServer` to `27-interchain-accounts` which exposes two distinct rpc endpoints:
>
> - `RegisterAccount`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/architecture/adr-009-v6-ics27-msgserver.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-v6-ics27-msgserver.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-v6-ics27-msgserver.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-v6-ics27-msgserver.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-v6-ics27-msgserver.md Outdated Show resolved Hide resolved
Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and succinct!

@@ -0,0 +1,110 @@
# ADR 009: ICS27 message server addition
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# ADR 009: ICS27 message server addition
# ADR 009: ICS27 Message Server Addition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we follow google style recommendations which only capitalizes the first word in a title cc @crodriguezvega should I capitalize Message?

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great nice job!

@mergify mergify bot merged commit c582e8a into main Sep 28, 2022
@mergify mergify bot deleted the colin/adr9-ics27-simplification branch September 28, 2022 12:25
mergify bot pushed a commit that referenced this pull request Sep 28, 2022
## Description

Covers the changes proposed for ibc-go v6

closes: #XXXX

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [ ] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes

(cherry picked from commit c582e8a)
colin-axner added a commit that referenced this pull request Sep 28, 2022
## Description

Covers the changes proposed for ibc-go v6

closes: #XXXX

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [ ] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes

(cherry picked from commit c582e8a)

Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants