Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding IsMiddlewareEnabled to ActiveChannel genesis type #2177

Merged
merged 9 commits into from
Sep 8, 2022

Conversation

damiannolan
Copy link
Member

Description

closes: #2165


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Ultra clean addition

ConnectionId: keySplit[2],
PortId: keySplit[1],
ChannelId: string(iterator.Value()),
IsMiddlewareEnabled: k.IsMiddlewareEnabled(ctx, keySplit[1], string(iterator.Value())),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, I think it'd probably be wise to set these key splits/iterator values to variables for readability purposes. I don't think it needs to change as this is a problem throughout our codebase (keysplit should probably be a parse func)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed! :)

@damiannolan damiannolan changed the title chore(draft): adding IsMiddlewareEnabled to ActiveChannel genesis type chore: adding IsMiddlewareEnabled to ActiveChannel genesis type Sep 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2177 (474b0be) into main (96b0aae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2177   +/-   ##
=======================================
  Coverage   79.48%   79.49%           
=======================================
  Files         173      173           
  Lines       12011    12015    +4     
=======================================
+ Hits         9547     9551    +4     
  Misses       2042     2042           
  Partials      422      422           
Impacted Files Coverage Δ
...7-interchain-accounts/controller/keeper/genesis.go 91.30% <100.00%> (+1.30%) ⬆️
...27-interchain-accounts/controller/keeper/keeper.go 92.74% <100.00%> (+0.05%) ⬆️

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@damiannolan damiannolan enabled auto-merge (squash) September 8, 2022 09:59
@damiannolan damiannolan merged commit b836b7f into main Sep 8, 2022
@damiannolan damiannolan deleted the damian/2165-ics27-genesis-state-updates branch September 8, 2022 10:31
mergify bot pushed a commit that referenced this pull request Sep 8, 2022
…2177)

* adding IsMiddlewareEnabled flag to ActiveChannel genesis type

* correcting yaml tag

* adding changelog entry

* Update proto/ibc/applications/interchain_accounts/genesis/v1/genesis.proto

Co-authored-by: Carlos Rodriguez <[email protected]>

Co-authored-by: Carlos Rodriguez <[email protected]>
(cherry picked from commit b836b7f)

# Conflicts:
#	CHANGELOG.md
colin-axner added a commit that referenced this pull request Sep 8, 2022
…backport #2177) (#2224)

* chore: adding `IsMiddlewareEnabled` to `ActiveChannel` genesis type (#2177)

* adding IsMiddlewareEnabled flag to ActiveChannel genesis type

* correcting yaml tag

* adding changelog entry

* Update proto/ibc/applications/interchain_accounts/genesis/v1/genesis.proto

Co-authored-by: Carlos Rodriguez <[email protected]>

Co-authored-by: Carlos Rodriguez <[email protected]>
(cherry picked from commit b836b7f)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

Co-authored-by: Damian Nolan <[email protected]>
Co-authored-by: Colin Axnér <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new field to ica controller genesis to track middleware enabled state
6 participants