Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing tx flags for update and misbehaviour commands in client #2171

Merged

Conversation

jhernandezb
Copy link
Contributor

@jhernandezb jhernandezb commented Aug 31, 2022

Description

Fix missing tx flags for the following commands

[appd] tx ibc client update
[appd] tx ibc client misbehaviour

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@colin-axner colin-axner merged commit 4adc069 into cosmos:main Sep 6, 2022
mergify bot pushed a commit that referenced this pull request Sep 6, 2022
…2171)

(cherry picked from commit 4adc069)

# Conflicts:
#	modules/core/02-client/client/cli/tx.go
mergify bot pushed a commit that referenced this pull request Sep 6, 2022
…2171)

(cherry picked from commit 4adc069)

# Conflicts:
#	modules/core/02-client/client/cli/tx.go
crodriguezvega pushed a commit that referenced this pull request Sep 7, 2022
…(backport #2171) (#2198)

* fix: missing tx flags for update and misbehaviour commands in client (#2171)

(cherry picked from commit 4adc069)

# Conflicts:
#	modules/core/02-client/client/cli/tx.go

* fix conflicts

Co-authored-by: Jorge Hernandez <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
crodriguezvega pushed a commit that referenced this pull request Sep 7, 2022
…(backport #2171) (#2197)

* fix: missing tx flags for update and misbehaviour commands in client (#2171)

(cherry picked from commit 4adc069)

# Conflicts:
#	modules/core/02-client/client/cli/tx.go

* fix conflicts

Co-authored-by: Jorge Hernandez <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants