-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing tx flags for update and misbehaviour commands in client #2171
Merged
colin-axner
merged 1 commit into
cosmos:main
from
public-awesome:jhernandezb/fix-missing-tx-flags
Sep 6, 2022
Merged
fix: missing tx flags for update and misbehaviour commands in client #2171
colin-axner
merged 1 commit into
cosmos:main
from
public-awesome:jhernandezb/fix-missing-tx-flags
Sep 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhernandezb
requested review from
colin-axner,
AdityaSripal,
seantking and
damiannolan
as code owners
August 31, 2022 18:07
damiannolan
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
colin-axner
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
crodriguezvega
pushed a commit
that referenced
this pull request
Sep 7, 2022
…(backport #2171) (#2198) * fix: missing tx flags for update and misbehaviour commands in client (#2171) (cherry picked from commit 4adc069) # Conflicts: # modules/core/02-client/client/cli/tx.go * fix conflicts Co-authored-by: Jorge Hernandez <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
crodriguezvega
pushed a commit
that referenced
this pull request
Sep 7, 2022
…(backport #2171) (#2197) * fix: missing tx flags for update and misbehaviour commands in client (#2171) (cherry picked from commit 4adc069) # Conflicts: # modules/core/02-client/client/cli/tx.go * fix conflicts Co-authored-by: Jorge Hernandez <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix missing tx flags for the following commands
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes