Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updating v3->v4 migration docs with fee middleware #2127

Merged
merged 5 commits into from
Sep 26, 2022
Merged

docs: updating v3->v4 migration docs with fee middleware #2127

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9a045f9
updating v3->v4 migration docs with fee middleware
seantking Aug 25, 2022
14e674e
fix: docs
seantking Aug 25, 2022
28ef34f
Merge branch 'main' into sean/issue#2089-fee-middleware-migration-docs
colin-axner Sep 21, 2022
a4189df
self requests
colin-axner Sep 21, 2022
2979e11
Merge branch 'main' into sean/issue#2089-fee-middleware-migration-docs
damiannolan Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/migrations/v3-to-v4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@ No genesis or in-place migrations required when upgrading from v1 or v2 of ibc-g

## Chains

### Fee Middleware

The Fee Middleware module, as the name suggests, plays the role of an IBC middleware and as such must be configured by chain developers to route and handle IBC messages correctly.

Please read the Fee Middleware [integration documentation](https://ibc.cosmos.network/main/middleware/ics29-fee/integration.html) for an in depth guide on how to congfigure the module correctly in order to incentivize IBC packets.
colin-axner marked this conversation as resolved.
Show resolved Hide resolved

### Migration to fix support for base denoms with slashes

As part of [v1.5.0](https://github.com/cosmos/ibc-go/releases/tag/v1.5.0), [v2.3.0](https://github.com/cosmos/ibc-go/releases/tag/v2.3.0) and [v3.1.0](https://github.com/cosmos/ibc-go/releases/tag/v3.1.0) some [migration handler code sample was documented](https://github.com/cosmos/ibc-go/blob/main/docs/migrations/support-denoms-with-slashes.md#upgrade-proposal) that needs to run in order to correct the trace information of coins transferred using ICS20 whose base denom contains slashes.
Expand Down Expand Up @@ -125,6 +131,8 @@ if err := k.icaControllerKeeper.RegisterInterchainAccount(ctx, msg.ConnectionId,
}
```

In order to incentivize ICS27 packets using the fee middleware module a middleware stack that contains the fee middleware must be configured. Take a look at the following diff for an [example setup](https://github.com/cosmos/ibc-go/pull/1432/files#diff-d18972debee5e64f16e40807b2ae112ddbe609504a93ea5e1c80a5d489c3a08aL366).
colin-axner marked this conversation as resolved.
Show resolved Hide resolved

## Relayers

When using the `DenomTrace` gRPC, the full IBC denomination with the `ibc/` prefix may now be passed in.
Expand Down