Add nil checks on the controller module for underlying app #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ller-module-for-underlying-app
chatton
requested review from
seantking,
colin-axner,
AdityaSripal and
damiannolan
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2102 +/- ##
=======================================
Coverage 80.03% 80.03%
=======================================
Files 170 170
Lines 11813 11823 +10
=======================================
+ Hits 9454 9463 +9
- Misses 1941 1942 +1
Partials 418 418
|
…ller-module-for-underlying-app
…ller-module-for-underlying-app
…ller-module-for-underlying-app
…ller-module-for-underlying-app
…ller-module-for-underlying-app
colin-axner
reviewed
Aug 25, 2022
modules/apps/27-interchain-accounts/controller/ibc_middleware.go
Outdated
Show resolved
Hide resolved
modules/apps/27-interchain-accounts/controller/ibc_middleware_test.go
Outdated
Show resolved
Hide resolved
modules/apps/27-interchain-accounts/controller/ibc_middleware_test.go
Outdated
Show resolved
Hide resolved
colin-axner
approved these changes
Aug 25, 2022
|
Could you add a changelog entry indicating nil apps are allowed in ics27 controller middleware? |
…ller-module-for-underlying-app
seantking
approved these changes
Aug 25, 2022
…ller-module-for-underlying-app
…ller-module-for-underlying-app
chatton
deleted the
cian/issue#2040-add-nil-checks-on-the-controller-module-for-underlying-app
branch
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2022
(cherry picked from commit dcd616c) # Conflicts: # CHANGELOG.md
colin-axner
added a commit
that referenced
this pull request
Aug 31, 2022
…2102) (#2131) * Add nil checks on the controller module for underlying app (#2102) (cherry picked from commit dcd616c) # Conflicts: # CHANGELOG.md * fix conflicts Co-authored-by: Cian Hatton <[email protected]> Co-authored-by: Colin Axnér <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #2040
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes