-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve error messages #203
Conversation
@@ -568,7 +568,7 @@ func produceVerificationArgs( | |||
|
|||
consensusState, err = GetConsensusState(store, cdc, height) | |||
if err != nil { | |||
return commitmenttypes.MerkleProof{}, nil, err | |||
return commitmenttypes.MerkleProof{}, nil, sdkerrors.Wrap(err, "please ensure the proof was constructed against the height the client was updated to") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any other way to word this?
Codecov Report
@@ Coverage Diff @@
## main #203 +/- ##
=======================================
Coverage 80.26% 80.26%
=======================================
Files 109 109
Lines 6485 6485
=======================================
Hits 5205 5205
Misses 925 925
Partials 355 355
|
Co-authored-by: Aditya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
we are adding a stracktrace for error messages, in case you are interested in taking a look: evmos/ethermint#50 |
…n to ensure PENDING-CHANGELOG.md is updated on every commit to main (cosmos#203)
Description
addresses comment
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes