fix: change non nil relayer check to non empty #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change relayers != nil to len(relayers) != 0 Rename ErrRelayersNotNil to ErrRelayersNotEmpty Add test cases
colin-axner
requested review from
AdityaSripal,
seantking,
charleenfei and
damiannolan
as code owners
crodriguezvega
approved these changes
Jul 26, 2022
Codecov Report
@@ Coverage Diff @@
## main #1774 +/- ##
=======================================
Coverage 80.04% 80.04%
=======================================
Files 166 166
Lines 12421 12421
=======================================
Hits 9943 9943
Misses 2013 2013
Partials 465 465
|
…go into colin/1773-ics29-genesis-fix
mergify bot
pushed a commit
that referenced
this pull request
Jul 27, 2022
* change non nil relayer check to non empty Change relayers != nil to len(relayers) != 0 Rename ErrRelayersNotNil to ErrRelayersNotEmpty Add test cases * add changelog entry (cherry picked from commit 126ab2d) # Conflicts: # CHANGELOG.md
damiannolan
pushed a commit
that referenced
this pull request
Jul 27, 2022
* fix: change non nil relayer check to non empty (#1774) * change non nil relayer check to non empty Change relayers != nil to len(relayers) != 0 Rename ErrRelayersNotNil to ErrRelayersNotEmpty Add test cases * add changelog entry (cherry picked from commit 126ab2d) # Conflicts: # CHANGELOG.md * fix changelog conflicts Co-authored-by: colin axnér <[email protected]>
ulbqb
pushed a commit
to ulbqb/ibc-go
that referenced
this pull request
Jul 27, 2023
…cosmos#1790) * fix: change non nil relayer check to non empty (cosmos#1774) * change non nil relayer check to non empty Change relayers != nil to len(relayers) != 0 Rename ErrRelayersNotNil to ErrRelayersNotEmpty Add test cases * add changelog entry (cherry picked from commit 126ab2d) # Conflicts: # CHANGELOG.md * fix changelog conflicts Co-authored-by: colin axnér <[email protected]>
ulbqb
pushed a commit
to ulbqb/ibc-go
that referenced
this pull request
Jul 31, 2023
…cosmos#1790) * fix: change non nil relayer check to non empty (cosmos#1774) * change non nil relayer check to non empty Change relayers != nil to len(relayers) != 0 Rename ErrRelayersNotNil to ErrRelayersNotEmpty Add test cases * add changelog entry (cherry picked from commit 126ab2d) # Conflicts: # CHANGELOG.md * fix changelog conflicts Co-authored-by: colin axnér <[email protected]>
ulbqb
pushed a commit
to ulbqb/ibc-go
that referenced
this pull request
Jul 31, 2023
…cosmos#1790) * fix: change non nil relayer check to non empty (cosmos#1774) * change non nil relayer check to non empty Change relayers != nil to len(relayers) != 0 Rename ErrRelayersNotNil to ErrRelayersNotEmpty Add test cases * add changelog entry (cherry picked from commit 126ab2d) # Conflicts: # CHANGELOG.md * fix changelog conflicts Co-authored-by: colin axnér <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1773
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes