-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: restructuring 06-solomachine lightclient directory layout #1679
chore: restructuring 06-solomachine lightclient directory layout #1679
Conversation
@@ -2,7 +2,7 @@ syntax = "proto3"; | |||
|
|||
package ibc.lightclients.solomachine.v2; | |||
|
|||
option go_package = "github.com/cosmos/ibc-go/v3/modules/light-clients/06-solomachine/types"; | |||
option go_package = "github.com/cosmos/ibc-go/v3/modules/light-clients/06-solomachine;solomachine"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly to the 07-tendermint
PR. This part is necessary in order to have the go package definition conform to package solomachine
while existing within the 06-solomachine
directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldnt we add a note that this is API breaking to the CHANGELOG? otherwise LGTM
…mian/124-solomachine-folder-layout
Codecov Report
@@ Coverage Diff @@
## damian/124-modify-lightclient-folder-structure #1679 +/- ##
==================================================================================
- Coverage 79.97% 79.96% -0.02%
==================================================================================
Files 165 166 +1
Lines 11746 11748 +2
==================================================================================
Hits 9394 9394
- Misses 1904 1906 +2
Partials 448 448
|
* restructuring 07-tendermint lightclient directory tree * adding changelog entry * chore: restructuring 06-solomachine lightclient directory layout (#1679) * restructing 06-solomachine folder layout * tidy go modules * fixing dead link * adding changelog entry
…os#1677) * restructuring 07-tendermint lightclient directory tree * adding changelog entry * chore: restructuring 06-solomachine lightclient directory layout (cosmos#1679) * restructing 06-solomachine folder layout * tidy go modules * fixing dead link * adding changelog entry
Description
06-solomachine/types
to06-solomachine
ref: #124
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes