Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero out client state before upgrading client proof #1674

Merged
merged 5 commits into from
Jul 11, 2022
Merged

Zero out client state before upgrading client proof #1674

merged 5 commits into from
Jul 11, 2022

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Jul 8, 2022 •
edited
Loading

Description

closes: #292

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@chatton chatton mentioned this pull request Jul 8, 2022
Closed
9 tasks
@chatton chatton marked this pull request as ready for review July 8, 2022 09:09
charleenfei
charleenfei approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@charleenfei charleenfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

colin-axner
colin-axner approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and clean. Great job!

I left a small nit regarding documentation.. Please let me know if you have any questions

modules/light-clients/07-tendermint/types/upgrade.go Outdated Show resolved Hide resolved
AdityaSripal
AdityaSripal approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chatton

@chatton chatton merged commit 60e5305 into 02-client-refactor Jul 11, 2022
@chatton chatton deleted the cian/issue#1530-zero-out-client-state-before-processing-upgraded-client-proof branch July 11, 2022 15:07
@colin-axner colin-axner mentioned this pull request Jul 12, 2022
Closed
3 tasks
oshorefueled pushed a commit to ComposableFi/ibc-go that referenced this pull request Aug 9, 2022
@chatton @oshorefueled
Zero out client state before upgrading client proof (cosmos#1674)
f7d7c37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@charleenfei charleenfei charleenfei approved these changes

@AdityaSripal AdityaSripal AdityaSripal approved these changes

@fedekunze fedekunze Awaiting requested review from fedekunze

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@seantking seantking Awaiting requested review from seantking

@damiannolan damiannolan Awaiting requested review from damiannolan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chatton @AdityaSripal @charleenfei @colin-axner