ibc-go v5: cosmos-sdk 46 #1653
ibc-go v5: cosmos-sdk 46 #1653
Conversation
faddat
requested review from
AdityaSripal,
seantking,
charleenfei,
colin-axner,
damiannolan,
fedekunze,
crodriguezvega and
chatton
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
can anyone approve this workflow please |
Codecov Report
@@ Coverage Diff @@
## main #1653 +/- ##
=======================================
Coverage 79.91% 79.92%
=======================================
Files 166 166
Lines 12434 12432 -2
=======================================
- Hits 9937 9936 -1
+ Misses 2030 2028 -2
- Partials 467 468 +1
|
|
I opened this PR, which, I think, fixes |
|
I'll test it now, on a machine where it didn't work before. |
fix for make proto-all
|
Hey, I've merged your PR, and I'm now going to fix another issue in the Makefile. |
|
All set -- so, running: make proto-update-deps in sequence now works for me perfectly. The change was to make sure that proofs.proto ended up in the root, how buf expected it. @vuong177 @nghuyenthevinh2000 @catShaark any additional thoughts on this one? Eg, final cleanups and the like? |
|
@faddat When I run Does anybody experience the same error? Also, do you mind to run |
|
happy to that looks like I made a typo maybe? |
|
Just tried update-deps works fine on my mac and in gitpod |
|
sed: 1: "third_party/proto/proof ...": undefined label 'hird_party/proto/proofs.proto' if you got that somewhere... its gotta be somewhere right? I am going to search the code... Update: it's really odd:
CONFIO_TYPES = third_party/proto
proto-update-deps:
@mkdir -p $(GOGO_PROTO_TYPES)
@curl -sSL $(GOGO_PROTO_URL)/gogoproto/gogo.proto > $(GOGO_PROTO_TYPES)/gogo.proto
@mkdir -p $(SDK_QUERY)
@curl -sSL $(SDK_PROTO_URL)/base/query/v1beta1/pagination.proto > $(SDK_QUERY)/pagination.proto
@mkdir -p $(SDK_BASE)
@curl -sSL $(SDK_PROTO_URL)/base/v1beta1/coin.proto > $(SDK_BASE)/coin.proto
@mkdir -p $(SDK_UPGRADE)
@curl -sSL $(SDK_PROTO_URL)/upgrade/v1beta1/upgrade.proto > $(SDK_UPGRADE)/v1beta1/upgrade.proto
## Importing of tendermint protobuf definitions currently requires the
## use of `sed` in order to build properly with cosmos-sdk's proto file layout
## (which is the standard Buf.build FILE_LAYOUT)
## Issue link: https://github.com/tendermint/tendermint/issues/5021
@mkdir -p $(TM_TYPES)
@curl -sSL $(TM_URL)/types/types.proto > $(TM_TYPES)/types.proto
@curl -sSL $(TM_URL)/types/validator.proto > $(TM_TYPES)/validator.proto
@mkdir -p $(TM_VERSION)
@curl -sSL $(TM_URL)/version/types.proto > $(TM_VERSION)/types.proto
@mkdir -p $(TM_LIBS)
@curl -sSL $(TM_URL)/libs/bits/types.proto > $(TM_LIBS)/types.proto
@mkdir -p $(TM_CRYPTO_TYPES)
@curl -sSL $(TM_URL)/crypto/proof.proto > $(TM_CRYPTO_TYPES)/proof.proto
@curl -sSL $(TM_URL)/crypto/keys.proto > $(TM_CRYPTO_TYPES)/keys.proto
@mkdir -p $(CONFIO_TYPES)
@curl -sSL $(CONFIO_URL)/proofs.proto > $(CONFIO_TYPES)/proofs.proto
## insert go package option into proofs.proto file
## Issue link: https://github.com/confio/ics23/issues/32
@sed -i '4ioption go_package = "github.com/confio/ics23/go";' $(CONFIO_TYPES)/proofs.proto
.PHONY: proto-all proto-gen proto-gen-any proto-swagger-gen proto-format proto-lint proto-check-breaking proto-update-deps |
|
Carlos, feels mildly silly to ask these q's but .... What os/setup do you use? stumped on makefile stuff |
Hi @faddat. Thanks for checking! I am on Big Sur and I was on the right branch. I talked to @damiannolan and he also had the same problem on his machine, but I have tried now to run |
|
The issue @crodriguezvega is facing is a mac issue with
|
There was a problem hiding this comment.
Followup ACK. Excellent work @faddat and everyone else who contributed! Thanks for the speedy response time and applying all our suggestions
Looking forward to seeing this in a final release 🚀 🎉
|
If it appeases it, let's do it. |
There was a problem hiding this comment.
Awesome work! And many thanks!
It would be nice to update the CONFIO_URL to point to the v0.7.1 release version.
Lets not block on the mac os sed issue, we can address it later or more importantly address the root cause from cosmos/ics23#32
LGTM! 🚀
There was a problem hiding this comment.
Awesome, @faddat! Thanks so much for this work; this has been a fun ride! 🤠
* Backport part of cosmos#1653 * Replace with finschia-sdk * Fix proto files * Fix for finschia * Backport part of cosmos#1653 * Fix wrong test * Update to go 1.20 * Disable markdown-link-check * Add NOTICE * Add CHANGELOG for finschia
Description
Cosmos sdk v46 changes to ibc-go
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes