Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Handler types #162

Merged
merged 4 commits into from
May 10, 2021
Merged

remove Handler types #162

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
53d43e2
remove unused handler
colin-axner May 7, 2021
6aff2f2
remove transfer handler
colin-axner May 7, 2021
f0d15c3
changelog
colin-axner May 7, 2021
eb76a31
fix merge conlicts
colin-axner May 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### API Breaking

* (modules) [\#162](https://github.com/cosmos/ibc-go/pull/162) Remove deprecated Handler types in core IBC and the ICS 20 transfer module.
* (modules) [\#140](https://github.com/cosmos/ibc-go/pull/140) IsFrozen() client state interface changed to Status(). gRPC `ClientStatus` route added.
* (modules/core) [\#109](https://github.com/cosmos/ibc-go/pull/109) Remove connection and channel handshake CLI commands.
* (modules) [\#107](https://github.com/cosmos/ibc-go/pull/107) Modify OnRecvPacket callback to return an acknowledgement which indicates if it is successful or not. Callback state changes are discarded for unsuccessful acknowledgements only.
Expand Down
23 changes: 0 additions & 23 deletions modules/apps/transfer/handler.go
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion modules/apps/transfer/module.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ func (AppModule) RegisterInvariants(ir sdk.InvariantRegistry) {

// Route implements the AppModule interface
func (am AppModule) Route() sdk.Route {
return sdk.NewRoute(types.RouterKey, NewHandler(am.keeper))
return sdk.Route{}
Copy link
Contributor Author

@colin-axner colin-axner May 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDK will know this is empty

}

// QuerierRoute implements the AppModule interface
Expand Down
0 modules/apps/transfer/handler_test.go → modules/apps/transfer/transfer_test.go
View file
Open in desktop
File renamed without changes.
98 changes: 0 additions & 98 deletions modules/core/handler.go
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion modules/core/module.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func (am AppModule) RegisterInvariants(ir sdk.InvariantRegistry) {

// Route returns the message routing key for the ibc module.
func (am AppModule) Route() sdk.Route {
return sdk.NewRoute(host.RouterKey, NewHandler(*am.keeper))
return sdk.Route{}
}

// QuerierRoute returns the ibc module's querier route name.
Expand Down