-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: emitting an event when handling a client upgrade proposal #1570
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3a21b99
feat: emitting an event when handling a client upgrade proposal
seantking 2994d3a
Merge branch 'main' into sean/issue#1558-emit-event-upgrade
seantking 597a5a9
Merge branch 'main' into sean/issue#1558-emit-event-upgrade
seantking a2ac339
refactor: only emit event if err is nil
seantking c3fee83
refactor: idiotmatic go:
seantking 2284ef2
Merge branch 'main' into sean/issue#1558-emit-event-upgrade
seantking c84a2d8
Merge branch 'main' into sean/issue#1558-emit-event-upgrade
seantking File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't know what the right answer is, but should we emit the event only if
k.upgradeKeeper.SetUpgradedClient(ctx, p.Plan.Height, bz)
succeeds?If not, should we first execute
err := k.upgradeKeeper.SetUpgradedClient(ctx, p.Plan.Height, bz)
and add to the event a string with the error fromerr
in case this call fails?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea 🤝
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just emit the event if there is no error returned. The hermes relayer will only try to do the upgrade after picking up the event so I don't see why they would want to do that if the upgrade won't happen?
I am not 100% clear on how this upgrade flow operates though. I see we first call
ScheduleUpgrade
and thenSetUpgradedClient
. I'm assuming ifSetUpgradeClient
fails the upgrade won't go ahead?cc: @AdityaSripal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes if the handler errors, then the state updates made during the handler gets reverted:
https://github.com/cosmos/cosmos-sdk/blob/main/x/gov/abci.go#L73