Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding fee middleware support to ics27 interchain accounts #1432

Merged
merged 10 commits into from
Jun 8, 2022

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented May 25, 2022

Description

The following PR adds support to apps/27-interchain-accounts to work in an application stack composed with apps/29-fee.

  • Adding additional version arg to RegisterInterchainAccount and updating godocs.
  • Removing the construction of ics27 metadata within RegisterInterchainAccount and passing through the new version arg to MsgChannelOpenInit directly - this supports both fee-disabled and fee-enabled channels in an application stack composed with ics29 middleware.
  • Updating simapp to include 29-fee in interchain accounts controller and host app stacks.
  • Updating test cases to adhere to changes
  • Adding migration docs

closes: #1356


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work, @damiannolan!

docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Outdated Show resolved Hide resolved
docs/migrations/v3-to-v4.md Show resolved Hide resolved
Co-authored-by: Carlos Rodriguez <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #1432 (8b754f2) into main (abd577e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1432      +/-   ##
==========================================
+ Coverage   80.34%   80.36%   +0.01%     
==========================================
  Files         166      166              
  Lines       12081    12088       +7     
==========================================
+ Hits         9707     9715       +8     
  Misses       1918     1918              
+ Partials      456      455       -1     
Impacted Files Coverage Δ
...7-interchain-accounts/controller/keeper/account.go 77.77% <100.00%> (+5.05%) ⬆️
modules/apps/29-fee/types/msgs.go 89.77% <100.00%> (ø)
...7-interchain-accounts/controller/ibc_middleware.go 83.33% <0.00%> (-3.71%) ⬇️
modules/apps/transfer/keeper/grpc_query.go 76.92% <0.00%> (-1.34%) ⬇️
modules/core/04-channel/keeper/events.go 100.00% <0.00%> (ø)
modules/core/04-channel/keeper/timeout.go 93.40% <0.00%> (+0.10%) ⬆️


The `WriteAcknowledgement` API now takes the `exported.Acknowledgement` type instead of passing in the acknowledgement byte array directly.
This is an API breaking change and as such IBC application developers will have to update any calls to `WriteAcknowledgement`.

The `OnChanOpenInit` application callback has been modified.
The return signature now includes the application version as detailed in the latest IBC [spec changes](https://github.com/cosmos/ibc/pull/629).

### ICS27 - Interchain Accounts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice docs!

@damiannolan damiannolan enabled auto-merge (squash) June 8, 2022 09:19
@damiannolan damiannolan merged commit 15a3280 into main Jun 8, 2022
@damiannolan damiannolan deleted the damian/1356-ica-fee-support branch June 8, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow interchain accounts to connect with middleware
4 participants