Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isolate packet fee distribution for on acknowledgement and on timeout into separate functions #1253

Merged
merged 2 commits into from
Apr 14, 2022
Merged

isolate packet fee distribution for on acknowledgement and on timeout into separate functions #1253

merged 2 commits into from
Apr 14, 2022

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Apr 13, 2022 •
edited
Loading

Description

Reduces the complexity contained in DistributePacketFees and DistributePacketFeesOnAcknowledgement in anticipation of #1251

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov-commenter
Copy link

Codecov Report

Merging #1253 (7a9ad20) into main (e59a6d2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1253   +/-   ##
=======================================
  Coverage   80.15%   80.16%           
=======================================
  Files         166      166           
  Lines       11943    11949    +6     
=======================================
+ Hits         9573     9579    +6     
  Misses       1912     1912           
  Partials      458      458
Impacted Files Coverage Δ
modules/apps/29-fee/keeper/escrow.go 88.88% <100.00%> (+0.60%) ⬆️

@mergify mergify bot merged commit eaff98b into main Apr 14, 2022
@mergify mergify bot deleted the colin/organize-ics29-distribution-code branch April 14, 2022 10:14
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this pull request Nov 6, 2023
@dependabot @gupadhyaya
build(deps): Bump github.com/multiformats/go-multiaddr from 0.11.0 to…
1f0ffdc 
… 0.12.0 (cosmos#1253)

Bumps
[github.com/multiformats/go-multiaddr](https://github.com/multiformats/go-multiaddr)
from 0.11.0 to 0.12.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/multiformats/go-multiaddr/releases">github.com/multiformats/go-multiaddr's
releases</a>.</em></p>
<blockquote>
<h2>v0.12.0</h2>
<h2>What's Changed</h2>
<ul>
<li>ci: uci/delete-templates by <a
href="https://github.com/web3-bot"><code>@​web3-bot</code></a> in <a
href="https://redirect.github.com/multiformats/go-multiaddr/pull/215">multiformats/go-multiaddr#215</a></li>
<li>ci: uci/copy-templates by <a
href="https://github.com/web3-bot"><code>@​web3-bot</code></a> in <a
href="https://redirect.github.com/multiformats/go-multiaddr/pull/216">multiformats/go-multiaddr#216</a></li>
<li>ci: uci/copy-templates by <a
href="https://github.com/web3-bot"><code>@​web3-bot</code></a> in <a
href="https://redirect.github.com/multiformats/go-multiaddr/pull/217">multiformats/go-multiaddr#217</a></li>
<li>net: consider dns addresses as public by <a
href="https://github.com/sukunrt"><code>@​sukunrt</code></a> in <a
href="https://redirect.github.com/multiformats/go-multiaddr/pull/220">multiformats/go-multiaddr#220</a></li>
<li>net: consider /dns/localhost as private address by <a
href="https://github.com/sukunrt"><code>@​sukunrt</code></a> in <a
href="https://redirect.github.com/multiformats/go-multiaddr/pull/221">multiformats/go-multiaddr#221</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/multiformats/go-multiaddr/compare/v0.11.0...v0.12.0">https://github.com/multiformats/go-multiaddr/compare/v0.11.0...v0.12.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/multiformats/go-multiaddr/commit/5dd793c6fc4935fad347429a48a168acc8073474"><code>5dd793c</code></a>
release v0.12.0 (<a
href="https://redirect.github.com/multiformats/go-multiaddr/issues/223">#223</a>)</li>
<li><a
href="https://github.com/multiformats/go-multiaddr/commit/f9a66bc382da9f5f5b319bd0d2beae7f63a253be"><code>f9a66bc</code></a>
net: consider /dns/localhost as private address (<a
href="https://redirect.github.com/multiformats/go-multiaddr/issues/221">#221</a>)</li>
<li><a
href="https://github.com/multiformats/go-multiaddr/commit/a12495439b7098bf1d3542b720fc6b0a7ca51b85"><code>a124954</code></a>
net: consider dns addresses as public (<a
href="https://redirect.github.com/multiformats/go-multiaddr/issues/220">#220</a>)</li>
<li><a
href="https://github.com/multiformats/go-multiaddr/commit/dfafc5928d51cb73d8e8347adc5f0b4babc897ca"><code>dfafc59</code></a>
chore: bump go.mod to Go 1.20 and run go fix (<a
href="https://redirect.github.com/multiformats/go-multiaddr/issues/217">#217</a>)</li>
<li><a
href="https://github.com/multiformats/go-multiaddr/commit/92a246dbc17f0a40027ce55fc1897c3797455e87"><code>92a246d</code></a>
Merge pull request <a
href="https://redirect.github.com/multiformats/go-multiaddr/issues/216">#216</a>
from multiformats/uci/copy-templates</li>
<li><a
href="https://github.com/multiformats/go-multiaddr/commit/db92edd85124f05554bd78f4cb910e3c0cde5b88"><code>db92edd</code></a>
chore: add or force update .github/workflows/tagpush.yml</li>
<li><a
href="https://github.com/multiformats/go-multiaddr/commit/438fa2383eeaf8c19c96da7107738044f3955752"><code>438fa23</code></a>
chore: add or force update .github/workflows/release-check.yml</li>
<li><a
href="https://github.com/multiformats/go-multiaddr/commit/841bae1eb4184543fc061c8b2b5d39dadf7db7fa"><code>841bae1</code></a>
chore: add or force update .github/workflows/releaser.yml</li>
<li><a
href="https://github.com/multiformats/go-multiaddr/commit/9bfab28ef3a3233cd3e2880557f06620c552e73a"><code>9bfab28</code></a>
chore: add or force update .github/workflows/go-check.yml</li>
<li><a
href="https://github.com/multiformats/go-multiaddr/commit/aeaad918987fa7783e45bc496ba9329686fb410a"><code>aeaad91</code></a>
chore: add or force update .github/workflows/go-test.yml</li>
<li>Additional commits viewable in <a
href="https://github.com/multiformats/go-multiaddr/compare/v0.11.0...v0.12.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/multiformats/go-multiaddr&package-manager=go_modules&previous-version=0.11.0&new-version=0.12.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ganesha Upadhyaya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seantking seantking seantking approved these changes

@damiannolan damiannolan damiannolan approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@charleenfei charleenfei Awaiting requested review from charleenfei

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@colin-axner @codecov-commenter @damiannolan @seantking