-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make EscrowPacketFee private #1252
Conversation
Annoying chore task. Thanks for looking into it! I'm mostly concerned about leaving out the checks we have in the removed I'm fine with leaving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK pending the additional testing checks in msg_server_test.go
as requested by @seantking
Great work! Not a fun pr to take on, but I'm a fan of the code improvement. Makes our tests slightly less nice, but I like having a clear entry point exposed to this functionality. Will prevent external developers from making mistakes. I feel pretty confident that someone would try to directly call EscrowPacketFee
instead of sending a PayPacketFee
message - thus bypassing the checks we have in place
Codecov Report
@@ Coverage Diff @@
## main #1252 +/- ##
==========================================
+ Coverage 80.15% 80.23% +0.08%
==========================================
Files 166 166
Lines 11943 11937 -6
==========================================
+ Hits 9573 9578 +5
+ Misses 1912 1905 -7
+ Partials 458 454 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but I noticed we don't check for the stored fees in escrow anymore -> https://github.com/cosmos/ibc-go/pull/1252/files#r850491652
Is this something we want to keep? I get it's somewhat redundant but may be a good safety check. I think it's worth adding.
Description
EscrowPacketFee
to be unexported -escrowPacketFee
IsFeeEnabled
checks tomsg_server.go
EscrowPacketFee
in tests. Explicitly set fees in escrow and send coins to module accountPayPacketFee
andPayPacketFeeAsync
tests to accommodate unexportedescrowPacketFee
closes: #1059
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes