Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding UpdateState to ClientState interface #1206

Merged

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Mar 30, 2022

Description

  • Adding UpdateState to ClientState interface
  • Updating function signatures and return values
  • Updating testcase TODOs to remove type casting

closes: #1194


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Comment on lines 62 to 64
// UpdateState updates and stores the ClientState and associated ConsensusState using the provided KVStore and ClientMessage Header
// An error is returned if ClientMessage is of type Misbehaviour
UpdateState(sdk.Context, codec.BinaryCodec, sdk.KVStore, ClientMessage) error
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open to suggestions for improving the godoc here :)

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Could you add a changelog entry too?

modules/core/exported/client.go Outdated Show resolved Hide resolved
@damiannolan damiannolan enabled auto-merge (squash) March 31, 2022 13:00
@damiannolan damiannolan merged commit eb48e54 into 02-client-refactor Mar 31, 2022
@damiannolan damiannolan deleted the damian/1194-add-updatestate-to-cs-interface branch March 31, 2022 13:07
seunlanlege pushed a commit to ComposableFi/ibc-go that referenced this pull request Aug 9, 2022
* adding UpdateState to ClientState interface and updating surrounds

* updating godoc

* adding changelog entry

* Update modules/core/exported/client.go

Co-authored-by: colin axnér <[email protected]>

* fixing typo in changelog

Co-authored-by: colin axnér <[email protected]>
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants