Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding VerifyClientMessage to ClientState interface #1196

Merged
merged 7 commits into from
Mar 30, 2022
Merged

Adding VerifyClientMessage to ClientState interface #1196

merged 7 commits into from
Mar 30, 2022

Conversation

seantking
Copy link
Contributor

Description

closes: #1191

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

damiannolan
damiannolan reviewed Mar 30, 2022
View reviewed changes
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was type casting in tests because VerifyClientMessage wasn't an interface function.
I think you can remove the TODOs are part of this PR.

I think its just these two tests:
https://github.com/cosmos/ibc-go/blob/02-client-refactor/modules/light-clients/07-tendermint/types/update_test.go#L385
https://github.com/cosmos/ibc-go/blob/02-client-refactor/modules/light-clients/07-tendermint/types/misbehaviour_handle_test.go#L779

@seantking
Copy link
Contributor Author

There was type casting in tests because VerifyClientMessage wasn't an interface function. I think you can remove the TODOs are part of this PR.

I think its just these two tests: https://github.com/cosmos/ibc-go/blob/02-client-refactor/modules/light-clients/07-tendermint/types/update_test.go#L385 https://github.com/cosmos/ibc-go/blob/02-client-refactor/modules/light-clients/07-tendermint/types/misbehaviour_handle_test.go#L779

Good catch 👍 Done

colin-axner
colin-axner approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

modules/core/exported/client.go Outdated Show resolved Hide resolved
@seantking seantking enabled auto-merge (squash) March 30, 2022 12:27
@seantking seantking merged commit 40183b4 into 02-client-refactor Mar 30, 2022
@seantking seantking deleted the sean/issue#1191-add-verify-client-to-client-interface branch March 30, 2022 12:35
@crodriguezvega crodriguezvega mentioned this pull request Mar 30, 2022
Closed
3 tasks
seunlanlege pushed a commit to ComposableFi/ibc-go that referenced this pull request Aug 9, 2022
@seantking @colin-axner
@damiannolan @seunlanlege
Adding VerifyClientMessage to ClientState interface (cosmos#1196)
d9f29cc 
* feat: adding VerifyClientMessage to ClientState interface

* fix: legacy

* remove todo + fix test

* Update modules/core/exported/client.go

Co-authored-by: colin axnér <[email protected]>

* Update modules/core/02-client/legacy/v100/solomachine.go

Co-authored-by: Damian Nolan <[email protected]>

* chore: changelog

Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this pull request Nov 6, 2023
@dependabot
build(deps): Bump github.com/celestiaorg/nmt from 0.19.0 to 0.20.0 (c…
92d41e5 
…osmos#1196)

Bumps [github.com/celestiaorg/nmt](https://github.com/celestiaorg/nmt)
from 0.19.0 to 0.20.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/celestiaorg/nmt/releases">github.com/celestiaorg/nmt's
releases</a>.</em></p>
<blockquote>
<h2>v0.20.0</h2>
<h2>What's Changed</h2>
<ul>
<li>chore: enable dependabot by <a
href="https://github.com/Chirag018"><code>@​Chirag018</code></a> in <a
href="https://redirect.github.com/celestiaorg/nmt/pull/234">celestiaorg/nmt#234</a></li>
<li>chore(deps): bump actions/checkout from 2 to 4 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/celestiaorg/nmt/pull/237">celestiaorg/nmt#237</a></li>
<li>chore(deps): bump codecov/codecov-action from 1 to 3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/celestiaorg/nmt/pull/236">celestiaorg/nmt#236</a></li>
<li>chore(deps): bump technote-space/get-diff-action from 4 to 6 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/celestiaorg/nmt/pull/235">celestiaorg/nmt#235</a></li>
<li>fix: replacing jsonProof with pb.Proof by <a
href="https://github.com/distractedm1nd"><code>@​distractedm1nd</code></a>
in <a
href="https://redirect.github.com/celestiaorg/nmt/pull/233">celestiaorg/nmt#233</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/Chirag018"><code>@​Chirag018</code></a>
made their first contribution in <a
href="https://redirect.github.com/celestiaorg/nmt/pull/234">celestiaorg/nmt#234</a></li>
<li><a
href="https://github.com/dependabot"><code>@​dependabot</code></a> made
their first contribution in <a
href="https://redirect.github.com/celestiaorg/nmt/pull/237">celestiaorg/nmt#237</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/celestiaorg/nmt/compare/v0.19.0...v0.20.0">https://github.com/celestiaorg/nmt/compare/v0.19.0...v0.20.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/celestiaorg/nmt/commit/8fb4edac8d4e4b97fd366abecbcbba563f3110f4"><code>8fb4eda</code></a>
fix: replacing jsonProof with pb.Proof (<a
href="https://redirect.github.com/celestiaorg/nmt/issues/233">#233</a>)</li>
<li><a
href="https://github.com/celestiaorg/nmt/commit/0e219c88a3471351159db7967a149d06aaa6dd50"><code>0e219c8</code></a>
chore(deps): bump technote-space/get-diff-action from 4 to 6 (<a
href="https://redirect.github.com/celestiaorg/nmt/issues/235">#235</a>)</li>
<li><a
href="https://github.com/celestiaorg/nmt/commit/7f7b27578a60e44f58f0e594a488ab9ee7937631"><code>7f7b275</code></a>
chore(deps): bump codecov/codecov-action from 1 to 3 (<a
href="https://redirect.github.com/celestiaorg/nmt/issues/236">#236</a>)</li>
<li><a
href="https://github.com/celestiaorg/nmt/commit/2587dcec669bd81cbec84ae65849f0c9af0e9025"><code>2587dce</code></a>
chore(deps): bump actions/checkout from 2 to 4 (<a
href="https://redirect.github.com/celestiaorg/nmt/issues/237">#237</a>)</li>
<li><a
href="https://github.com/celestiaorg/nmt/commit/8437fe1a7ef2e316ca377ccf9961f6005fa13b2b"><code>8437fe1</code></a>
chore: enable dependabot (<a
href="https://redirect.github.com/celestiaorg/nmt/issues/234">#234</a>)</li>
<li>See full diff in <a
href="https://github.com/celestiaorg/nmt/compare/v0.19.0...v0.20.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/celestiaorg/nmt&package-manager=go_modules&previous-version=0.19.0&new-version=0.20.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@damiannolan damiannolan damiannolan approved these changes

@fedekunze fedekunze Awaiting requested review from fedekunze

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@charleenfei charleenfei Awaiting requested review from charleenfei

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seantking @damiannolan @colin-axner