-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add GetAppVersion to ICS4Wrapper #1022
Conversation
Add a function to 04-channel keeper which can be used in the ICS4Wrapper interface for obtaining the unwrapped channel verison
I actually don't think I need this for #821 any longer, but it still seems useful |
Naming still needs to be decided. At the very least I think I can rename to Ideally we have something that conveys the version returned should be the version this layer of the stack was given |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-) Left a few mega nits
Co-authored-by: Sean King <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1022 +/- ##
=======================================
Coverage 80.30% 80.31%
=======================================
Files 166 166
Lines 11980 12004 +24
=======================================
+ Hits 9621 9641 +20
- Misses 1905 1908 +3
- Partials 454 455 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack latest! super clean, nice work!
Description
closes: #1002
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes