Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ParseKeyFeeInEscrowChannel function #988

Closed
3 tasks
colin-axner opened this issue Feb 23, 2022 · 1 comment
Closed
3 tasks

Create ParseKeyFeeInEscrowChannel function #988

colin-axner opened this issue Feb 23, 2022 · 1 comment
Assignees
@colin-axner
Labels
29-fee
Milestone
Fee middleware alpha

Comments

@colin-axner
Copy link
Contributor

Summary

Create a function to parse the KeyFeesInEscrow string. This allows for the key splitting to sit side by side the key creation. Should be done for each key, but this issue only refers to KeyFeesInEscrow as a start

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner self-assigned this Feb 23, 2022
@crodriguezvega crodriguezvega added this to the Fee Middleware milestone Feb 23, 2022
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Feb 23, 2022
@colin-axner colin-axner mentioned this issue Feb 24, 2022
Merged
9 tasks
@colin-axner
Copy link
Contributor Author

closed by #998

Repository owner moved this from Backlog to Done in ibc-go Feb 24, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@gupadhyaya
fix race in header exchange (cosmos#988)
c4c0f78 
This PR fixes the data race issue caused in the header exchange when the
syncer status is checked (in stop) and set (in start , separate go
routine).

Also fixes the golangci-lint errors. 

Blocking rollkit/rollkit#963 and
rollkit/rollkit#953 from merge.

---------

Co-authored-by: Ganesha Upadhyaya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
Fee middleware alpha
Development

No branches or pull requests
2 participants
@crodriguezvega @colin-axner