Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MsgPayPacketFeeAsync to include packet id and fee #975

Closed
3 tasks
damiannolan opened this issue Feb 22, 2022 · 0 comments
Closed
3 tasks

Update MsgPayPacketFeeAsync to include packet id and fee #975

damiannolan opened this issue Feb 22, 2022 · 0 comments
Assignees
@damiannolan
Labels
29-fee
Milestone
Fee middleware alpha

Comments

@damiannolan
Copy link
Member

Summary

With the changes made to ics29 fee storage to exclude the PacketId from the PacketFee (previously IdentifiedPacketFee) stored in state, MsgPayPacketFeeAsync should be updated to include the both the packet id as well as the packet fee in favour of the IdentifiedPacketFee type.

See comment

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added this to the Fee Middleware milestone Feb 22, 2022
@damiannolan damiannolan self-assigned this Feb 22, 2022
@damiannolan damiannolan moved this to In progress in ibc-go Feb 22, 2022
This was referenced Feb 22, 2022
Merged
Merged
@damiannolan damiannolan moved this from In progress to In review in ibc-go Feb 23, 2022
Repository owner moved this from In review to Done in ibc-go Feb 24, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@dependabot
build(deps): bump golangci/golangci-lint-action from 3.4.0 to 3.5.0 (c…
3385528 
…osmos#975)

Bumps
[golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action)
from 3.4.0 to 3.5.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/golangci/golangci-lint-action/releases">golangci/golangci-lint-action's
releases</a>.</em></p>
<blockquote>
<h2>v3.5.0</h2>
<h2>What's Changed</h2>
<ul>
<li>build(deps-dev): bump eslint from 8.32.0 to 8.33.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/659">golangci/golangci-lint-action#659</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.48.2 to 5.49.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/661">golangci/golangci-lint-action#661</a></li>
<li>build(deps-dev): bump eslint-plugin-simple-import-sort from 9.0.0 to
10.0.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/662">golangci/golangci-lint-action#662</a></li>
<li>build(deps-dev): bump <code>@​vercel/ncc</code> from 0.36.0 to
0.36.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/660">golangci/golangci-lint-action#660</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
5.48.2 to 5.49.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/663">golangci/golangci-lint-action#663</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.49.0 to 5.50.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/665">golangci/golangci-lint-action#665</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
5.49.0 to 5.50.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/666">golangci/golangci-lint-action#666</a></li>
<li>build(deps-dev): bump typescript from 4.9.4 to 4.9.5 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/667">golangci/golangci-lint-action#667</a></li>
<li>build(deps): bump <code>@​types/node</code> from 18.11.18 to
18.11.19 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/668">golangci/golangci-lint-action#668</a></li>
<li>doc: add quote aroung go version by <a
href="https://github.com/vaughany"><code>@​vaughany</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/670">golangci/golangci-lint-action#670</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
5.50.0 to 5.51.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/671">golangci/golangci-lint-action#671</a></li>
<li>build(deps-dev): bump prettier from 2.8.3 to 2.8.4 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/673">golangci/golangci-lint-action#673</a></li>
<li>build(deps): bump <code>@​types/node</code> from 18.11.19 to 18.13.0
by <a href="https://github.com/dependabot"><code>@​dependabot</code></a>
in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/674">golangci/golangci-lint-action#674</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.50.0 to 5.51.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/675">golangci/golangci-lint-action#675</a></li>
<li>build(deps): bump <code>@​actions/cache</code> from 3.1.2 to 3.1.3
by <a href="https://github.com/dependabot"><code>@​dependabot</code></a>
in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/672">golangci/golangci-lint-action#672</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
5.51.0 to 5.52.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/678">golangci/golangci-lint-action#678</a></li>
<li>build(deps): bump <code>@​types/node</code> from 18.13.0 to 18.14.0
by <a href="https://github.com/dependabot"><code>@​dependabot</code></a>
in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/679">golangci/golangci-lint-action#679</a></li>
<li>build(deps-dev): bump eslint from 8.33.0 to 8.34.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/680">golangci/golangci-lint-action#680</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.51.0 to 5.52.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/681">golangci/golangci-lint-action#681</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.52.0 to 5.53.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/684">golangci/golangci-lint-action#684</a></li>
<li>build(deps-dev): bump eslint from 8.34.0 to 8.35.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/685">golangci/golangci-lint-action#685</a></li>
<li>build(deps): bump <code>@​types/node</code> from 18.14.0 to 18.14.2
by <a href="https://github.com/dependabot"><code>@​dependabot</code></a>
in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/688">golangci/golangci-lint-action#688</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
5.52.0 to 5.53.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/687">golangci/golangci-lint-action#687</a></li>
<li>build(deps): bump <code>@​actions/cache</code> from 3.1.3 to 3.1.4
by <a href="https://github.com/dependabot"><code>@​dependabot</code></a>
in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/686">golangci/golangci-lint-action#686</a></li>
<li>build(deps): bump <code>@​types/node</code> from 18.14.2 to 18.14.6
by <a href="https://github.com/dependabot"><code>@​dependabot</code></a>
in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/691">golangci/golangci-lint-action#691</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
5.53.0 to 5.54.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/692">golangci/golangci-lint-action#692</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.53.0 to 5.54.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/693">golangci/golangci-lint-action#693</a></li>
<li>build(deps-dev): bump eslint-config-prettier from 8.6.0 to 8.7.0 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/694">golangci/golangci-lint-action#694</a></li>
<li>build(deps-dev): bump eslint from 8.35.0 to 8.36.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/699">golangci/golangci-lint-action#699</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.54.0 to 5.54.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/700">golangci/golangci-lint-action#700</a></li>
<li>build(deps): bump <code>@​types/node</code> from 18.14.6 to 18.15.1
by <a href="https://github.com/dependabot"><code>@​dependabot</code></a>
in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/701">golangci/golangci-lint-action#701</a></li>
<li>docs/build: update to setup-go@v4 by <a
href="https://github.com/caarlos0"><code>@​caarlos0</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/704">golangci/golangci-lint-action#704</a></li>
<li>build(deps-dev): bump typescript from 4.9.5 to 5.0.2 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/705">golangci/golangci-lint-action#705</a></li>
<li>build(deps): bump <code>@​types/node</code> from 18.15.1 to 18.15.3
by <a href="https://github.com/dependabot"><code>@​dependabot</code></a>
in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/706">golangci/golangci-lint-action#706</a></li>
<li>build(deps): bump <code>@​actions/http-client</code> from 2.0.1 to
2.1.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/697">golangci/golangci-lint-action#697</a></li>
<li>build(deps-dev): bump prettier from 2.8.4 to 2.8.5 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/707">golangci/golangci-lint-action#707</a></li>
<li>build(deps): bump <code>@​actions/cache</code> from 3.1.4 to 3.2.1
by <a href="https://github.com/dependabot"><code>@​dependabot</code></a>
in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/698">golangci/golangci-lint-action#698</a></li>
<li>build(deps-dev): bump eslint-config-prettier from 8.7.0 to 8.8.0 by
<a href="https://github.com/dependabot"><code>@​dependabot</code></a> in
<a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/709">golangci/golangci-lint-action#709</a></li>
<li>build(deps): bump <code>@​types/node</code> from 18.15.3 to 18.15.10
by <a href="https://github.com/dependabot"><code>@​dependabot</code></a>
in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/710">golangci/golangci-lint-action#710</a></li>
<li>build(deps-dev): bump prettier from 2.8.5 to 2.8.7 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/711">golangci/golangci-lint-action#711</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.54.1 to 5.56.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/712">golangci/golangci-lint-action#712</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
5.54.0 to 5.56.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/713">golangci/golangci-lint-action#713</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.56.0 to 5.57.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/718">golangci/golangci-lint-action#718</a></li>
<li>build(deps-dev): bump typescript from 5.0.2 to 5.0.3 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/717">golangci/golangci-lint-action#717</a></li>
<li>build(deps-dev): bump eslint from 8.36.0 to 8.37.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/719">golangci/golangci-lint-action#719</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
5.56.0 to 5.57.0 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/720">golangci/golangci-lint-action#720</a></li>
<li>build(deps): bump <code>@​types/node</code> from 18.15.10 to
18.15.11 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/721">golangci/golangci-lint-action#721</a></li>
<li>build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.57.0 to 5.57.1 by <a
href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a
href="https://redirect.github.com/golangci/golangci-lint-action/pull/722">golangci/golangci-lint-action#722</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/5f1fec7010f6ae3b84ea4f7b2129beb8639b564f"><code>5f1fec7</code></a>
build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
5.59.6 to 5.59.7 (<a
href="https://redirect.github.com/golangci/golangci-lint-action/issues/758">#758</a>)</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/601007b788a335933ba460298a9c9da82a9460b1"><code>601007b</code></a>
build(deps): bump <code>@​types/node</code> from 20.2.3 to 20.2.5 (<a
href="https://redirect.github.com/golangci/golangci-lint-action/issues/756">#756</a>)</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/d2a913e97bbaf8323bd27da961ba33426726000f"><code>d2a913e</code></a>
build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.59.6 to 5.59.7 ...</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/7233bd71cb7be55595200383f0b95fe1639ce9ed"><code>7233bd7</code></a>
build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.59.5 to 5.59.6 ...</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/687f029324d5666f0f5911bbbc7921193af5d8a4"><code>687f029</code></a>
build(deps): bump <code>@​types/node</code> from 20.1.4 to 20.2.3 (<a
href="https://redirect.github.com/golangci/golangci-lint-action/issues/755">#755</a>)</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/f9990cd216ef435f7c8f9afbb7e713dda02231c9"><code>f9990cd</code></a>
build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
5.59.5 to 5.59.6 (<a
href="https://redirect.github.com/golangci/golangci-lint-action/issues/754">#754</a>)</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/f30aa514f95287b12eb5bca55b54b8e026cde352"><code>f30aa51</code></a>
build(deps-dev): bump eslint from 8.40.0 to 8.41.0 (<a
href="https://redirect.github.com/golangci/golangci-lint-action/issues/753">#753</a>)</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/6b21f586ed8efa6be5638dfa9e4e1766e9da8bcf"><code>6b21f58</code></a>
build(deps-dev): bump <code>@​typescript-eslint/eslint-plugin</code>
from 5.59.2 to 5.59.5 ...</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/535ed3a04b2d201195fae99ee856f62d8582826b"><code>535ed3a</code></a>
build(deps): bump <code>@​types/semver</code> from 7.3.13 to 7.5.0 (<a
href="https://redirect.github.com/golangci/golangci-lint-action/issues/748">#748</a>)</li>
<li><a
href="https://github.com/golangci/golangci-lint-action/commit/0078ef00ab9386a0b13f3f1c1de23eace0a5d6c7"><code>0078ef0</code></a>
build(deps-dev): bump <code>@​typescript-eslint/parser</code> from
5.59.1 to 5.59.5 (<a
href="https://redirect.github.com/golangci/golangci-lint-action/issues/750">#750</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/golangci/golangci-lint-action/compare/v3.4.0...v3.5.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golangci/golangci-lint-action&package-manager=github_actions&previous-version=3.4.0&new-version=3.5.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
Fee middleware alpha
Development

No branches or pull requests
1 participant
@damiannolan