Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Fee Version format to JSON #756

Closed
AdityaSripal opened this issue Jan 18, 2022 · 2 comments
Closed

Change Fee Version format to JSON #756

AdityaSripal opened this issue Jan 18, 2022 · 2 comments
Assignees
@damiannolan
Labels
29-fee
Milestone
Fee middleware alpha

Comments

@AdityaSripal
Copy link
Member

AdityaSripal commented Jan 18, 2022 •
edited
Loading

Follow metadata best practices outlined in cosmos/ibc#638

{
    "fee": "ics29-1",
    "app": "app version",
}

cc: @colin-axner
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Jan 18, 2022
@colin-axner
Copy link
Contributor

colin-axner commented Jan 19, 2022 •
edited
Loading

Should it be version and appVersion? or maybe version and appMetadata?

@seantking seantking added this to the Fee Middleware milestone Jan 19, 2022
@crodriguezvega crodriguezvega moved this from Backlog to Todo in ibc-go Jan 24, 2022
@damiannolan damiannolan self-assigned this Feb 4, 2022
@damiannolan damiannolan moved this from Todo to In progress in ibc-go Feb 7, 2022
@damiannolan damiannolan mentioned this issue Feb 7, 2022
Merged
9 tasks
@damiannolan damiannolan moved this from In progress to In review in ibc-go Feb 8, 2022
@damiannolan damiannolan moved this from In review to Done in ibc-go Feb 9, 2022
@damiannolan
Copy link
Member

closed by #883

faddat pushed a commit to notional-labs/ibc-go that referenced this issue Feb 23, 2022
@pinosu
Add module name to buf.yml file (cosmos#756)
f043f19 
The module name is a required field as specified here:
https://docs.buf.build/bsr/overview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
Fee middleware alpha
Development

No branches or pull requests
4 participants
@damiannolan @seantking @AdityaSripal @colin-axner