Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move caching within the scope of the distribute function #649

Closed
charleenfei opened this issue Dec 21, 2021 · 0 comments
Closed

move caching within the scope of the distribute function #649

charleenfei opened this issue Dec 21, 2021 · 0 comments
Assignees
@charleenfei
Labels
29-fee
Milestone
Fee middleware alpha

Comments

@charleenfei
Copy link
Contributor

currently, an error on any one of the distributes from the escrow methods leads to the entire cached context to be discarded. this should be updated so that each error only fails that context.
@charleenfei charleenfei added this to the Fee Middleware milestone Dec 21, 2021
@charleenfei charleenfei self-assigned this Dec 21, 2021
@charleenfei charleenfei mentioned this issue Dec 22, 2021
Merged
9 tasks
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Jan 1, 2022
@crodriguezvega crodriguezvega moved this from Todo to In progress in ibc-go Jan 1, 2022
@crodriguezvega crodriguezvega moved this from In progress to In review in ibc-go Jan 10, 2022
Repository owner moved this from In review to Done in ibc-go Jan 12, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@joroshiba
Add Chain ID onto the Rollmint block (cosmos#649)
9df643f 
* Add Chain ID onto the Rollmint block since it is necessary for a correct hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charleenfei charleenfei

Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
Fee middleware alpha
Development

No branches or pull requests
2 participants
@seantking @charleenfei