Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simp does not use ibcante module #627

Closed
3 tasks
tac0turtle opened this issue Dec 13, 2021 · 2 comments · Fixed by #884
Closed
3 tasks

simp does not use ibcante module #627

tac0turtle opened this issue Dec 13, 2021 · 2 comments · Fixed by #884
Labels
type: bug Something isn't working as expected

Comments

@tac0turtle
Copy link
Member

Summary of Bug

Not sure if this on purpose but ibc simapp doesn't use the new ibc ante handler. The auth/ante handler doesn't define it as well.

Version

master

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner
Copy link
Contributor

This was accidental, we should add it

@crodriguezvega crodriguezvega added the type: bug Something isn't working as expected label Jan 3, 2022
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Jan 3, 2022
@colin-axner
Copy link
Contributor

closed by #884

Repository owner moved this from Backlog to Done in ibc-go Feb 10, 2022
@crodriguezvega crodriguezvega mentioned this issue Feb 10, 2022
Merged
9 tasks
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Feb 23, 2022
@alpe
Merge pull request cosmos#627 from CosmWasm/upgrade_sdk
5e88752 
Upgrade Cosmos-sdk v0.42.10
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@Manav-Aggarwal
Add Data Hash Validation to Block's ValidateBasic (cosmos#1200)
44b680c 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview
Closes: cosmos#627 
<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working as expected
Projects
ibc-go
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug: use custom ante handler to reject redundant transactions in simapp cosmos/ibc-go
3 participants
@crodriguezvega @tac0turtle @colin-axner