-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write tests for different sdk.Messages (TrySendTx) #510
Comments
@charleenfei can you share the user stories once you have written them (happy to help with this). We need to ensure that the teams planning to use this at launch are covered (what SDK messages are they planning to execute?). |
@colin-axner Am I correct in assuming that some of these tests will eventually need to live outside of the |
I still need to follow up directly with these teams to get a latest update on these stories, but as it is so far, a sample first three: Injective X Band Chain Umee X Hub Umee then stakes these ATOM tokens on the Hub on behalf of Umee (ATOMs get inflation rewards, etc). Without ICA, Umee would have to use validator controlled multisig, because for this flow Umee needs an account on the Hub which can be controlled externally in a decentralised way. This ICA registered on the Hub would then receive the staking rewards for the ATOM, figure out distribution back to Umee chain, and send back to the corresponding existing account on Umee. Hub Custodial Services An alternative is offering the custodial service through the Hub. When a new chain goes live, through IBC the tokens are transferred to the Hub and custodial services can use the tokens from X chain that have been passed through the Hub. This means that the custodial service would just have to integrate with one chain, rather with X. Using ICA, a service could be built in which a user sends tokens to an interchain account address on chain X, which corresponds to the registered ICA account of chain X on the Hub. This account would handle the token transfer to the Hub and then further on to the custodial wallet. |
I'm ok with using messages from the SDK, but we don't want to be dependent on other SDK modules (otherwise updating SDK versions will become difficult). Based on how the code is structured, I'm not too worried on testing all messages. Testing that the messages are executed and perform expected functionality is something that can live at the integration test level above the relayers |
* Release v0.16.0 changelog * Add section for api breaking changes
Summary
At present, we are only testing if bank msg send can be executed as part of the
TrySendTx
flow. See here.At a minimum, we should write unit tests that cover the execution of all the SDK messages required as part of our initial user stories/use cases.
Required messages (likely to be updated):
BeginRedelegate(ibc/testing only includes a single validator)For Admin Use
The text was updated successfully, but these errors were encountered: