-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go package to v2 #389
Comments
why do you need to update the go package too? |
This way we can import old code when we need to maintain backwards compatibility. This is especially useful for protobuf definitions which might change. For example, if the client state proto definition changes, we may want to import the v1 definition/implementation and decode the client state bytes into that definition for connections which cannot use the newer definition. We ran into this issue changing the version of solo machine which required migration code to reimplement the solo machine interface, if the migration code actually needed to use any of the interface functions, we would have had to maintain duplicate code, much easier to import. Having separate histories for each version of this go module may prove useful for external clients as well. This follows the golang module version, specifically when handling major version increments:
gaia does this as well. Happy to discuss the pros/cons, but changing imports per major version jump seems like low overhead for the potential benefits |
* added simulation params * fixed return types * implemented full sim test on wasmd * removed wrong committed github action * switched to a import export test since i'm introducing params and genesis simulations * fixed makefile * Fixed sim test flags not working * fixed some errors on sim test * fixed conflicts still a failure to be solved * fixed wasm params error * added missing codec * Update params.go removed unused import * fixed intellij cache errors * added full app simulation test that pass * added README.md for sims credits added me into contributors list Co-authored-by: riccardo.montagnin <[email protected]>
* Add wasmd scripts * Apply suggestions from code review Co-authored-by: colin axnér <[email protected]> Co-authored-by: colin axnér <[email protected]>
Summary
We want to do a v2 release with #350, since this contains API breaking changes, we should follow go semantic versioning by bumping our package version as well. The
go.mod
file will read:All imports will need to change. I think this will be beneficial long term as it'll allow us to reference old code/structures when we need to maintain backwards compatibility
For Admin Use
The text was updated successfully, but these errors were encountered: