Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide channel version in Recv, Acknowledge, and Timeout app callbacks #195

Closed
3 tasks
colin-axner opened this issue May 26, 2021 · 2 comments · Fixed by #6902
Closed
3 tasks

Provide channel version in Recv, Acknowledge, and Timeout app callbacks #195

colin-axner opened this issue May 26, 2021 · 2 comments · Fixed by #6902
Assignees
@gjermundgaraba
Milestone
v9.0.0

Comments

@colin-axner
Copy link
Contributor

Summary

Modify the core IBC API to return the channel to the message server. The message server should pass the channel version to the application callbacks

Problem Definition

Channel versions are useful when adding backwards compatible features to an existing application implementation. The channel is already loaded in core IBC, we should pass the channel version to the applications so they don't have to reload the channel

Proposal

Modify the 04-channel keeper functions to return the channels. Modify the application callbacks for Recv, Ack, and Timeout to take in the channel version

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the needs discussion Issues that need discussion before they can be worked on label May 26, 2021
@colin-axner colin-axner added this to the 2.0.0 milestone May 28, 2021
@crodriguezvega crodriguezvega modified the milestones: 2.0.0, vNext Sep 17, 2021
faddat referenced this issue in notional-labs/ibc-go Feb 23, 2022
@ethanfrey
Merge pull request #195 from CosmWasm/update_history
65e4e3a 
Full history of contract code migrations
@crodriguezvega crodriguezvega removed this from the Q2-2022-backlog milestone Mar 31, 2022
@colin-axner
Copy link
Contributor Author

Needs a spec change

@colin-axner colin-axner mentioned this issue Aug 11, 2022
Open
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@toanngosy @tzdybal
feat: add wait time before producing blocks (cosmos#278)
a972fac 
Resolves cosmos#195
Resolves cosmos#196

Co-authored-by: Tomasz Zdybał <[email protected]>
@colin-axner colin-axner moved this to Todo 🏃 in ibc-go Jul 16, 2024
@colin-axner colin-axner removed the needs discussion Issues that need discussion before they can be worked on label Jul 16, 2024
@colin-axner
Copy link
Contributor Author

We have decided to implement and include in v9 as middlewares acting on transfer will need access to the channel version

@crodriguezvega crodriguezvega added this to the v9.0.0 milestone Jul 17, 2024
@gjermundgaraba gjermundgaraba self-assigned this Jul 19, 2024
@gjermundgaraba gjermundgaraba mentioned this issue Jul 19, 2024
Merged
10 tasks
@gjermundgaraba gjermundgaraba linked a pull request Jul 19, 2024 that will close this issue
feat: add channel version to core app callbacks #6902
Merged
10 tasks
@gjermundgaraba gjermundgaraba moved this from Todo 🏃 to In review 👀 in ibc-go Jul 19, 2024
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🥳 in ibc-go Jul 26, 2024
@mergify mergify bot mentioned this issue Jul 26, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gjermundgaraba gjermundgaraba

Labels
None yet
Projects
ibc-go
Archived in project
Milestone
v9.0.0
Development

Successfully merging a pull request may close this issue.

feat: add channel version to core app callbacks cosmos/ibc-go
3 participants
@gjermundgaraba @crodriguezvega @colin-axner