Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more status check to CreateClient #186

Closed
2 of 6 tasks
colin-axner opened this issue May 21, 2021 · 4 comments · Fixed by #3514
Closed
2 of 6 tasks

Add more status check to CreateClient #186

colin-axner opened this issue May 21, 2021 · 4 comments · Fixed by #3514
Labels
02-client type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
v8.0.0

Comments

@colin-axner
Copy link
Contributor

colin-axner commented May 21, 2021 •
edited
Loading

Summary

A few places that could check the status of a client

  • CreateClient
  • ConnOpenInit
  • ChanOpenInit

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner mentioned this issue May 21, 2021
Closed
30 tasks
@colin-axner colin-axner added this to the 1.1.0 milestone May 28, 2021
@crodriguezvega crodriguezvega modified the milestones: 1.1.0, vNext Sep 17, 2021
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Jan 3, 2022
@crodriguezvega crodriguezvega added the type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. label Jan 3, 2022
faddat referenced this issue in notional-labs/ibc-go Feb 23, 2022
@ethanfrey
Merge pull request #186 from CosmWasm/toggle_gov_types_175
74e99b8 
Define enabled wasm gov proposal types
@crodriguezvega crodriguezvega removed this from the Q2-2022-backlog milestone Mar 31, 2022
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Nov 1, 2022
@colin-axner
Copy link
Contributor Author

This was fixed with the addition of the localhost (#3196 specifically). Status check is missing for CreateClient, but I think it can be assumed a non functional client will error in clientState.Initialize() call

@github-project-automation github-project-automation bot moved this from Backlog to Todo in ibc-go Mar 21, 2023
@colin-axner colin-axner reopened this Apr 12, 2023
@colin-axner
Copy link
Contributor Author

Lets be defensive and add the check to CreateClient

@colin-axner colin-axner changed the title Add more status checks Add more status check to CreateClient Apr 12, 2023
@DimitrisJim
Copy link
Contributor

the idea here is to basically check for the status after we initialize, right?

@crodriguezvega crodriguezvega added this to the v8.0.0 milestone Apr 15, 2023
@colin-axner
Copy link
Contributor Author

yup!

@DimitrisJim DimitrisJim linked a pull request Apr 24, 2023 that will close this issue
imp: add a check for the client status in CreateClient #3514
Merged
9 tasks
@DimitrisJim DimitrisJim mentioned this issue Apr 24, 2023
Merged
9 tasks
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@tzdybal
Actually fix a cosmos#184... (cosmos#186)
abec544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
02-client type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Archived in project
Milestone
v8.0.0
Development

Successfully merging a pull request may close this issue.

imp: add a check for the client status in CreateClient cosmos/ibc-go
3 participants
@crodriguezvega @DimitrisJim @colin-axner