Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify SendPacket interface #1395

Closed
3 tasks
colin-axner opened this issue May 18, 2022 · 0 comments · Fixed by #1703
Closed
3 tasks

Simplify SendPacket interface #1395

colin-axner opened this issue May 18, 2022 · 0 comments · Fixed by #1703
Assignees
@AdityaSripal
Milestone
v6.0.0

Comments

@colin-axner
Copy link
Contributor

colin-axner commented May 18, 2022 •
edited
Loading

Summary

Apply changes from cosmos/ibc#731 and it's followup prs

low priority, primarily an application developer UX improvement

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega added this to the Q4-2022-backlog milestone Jul 7, 2022
@AdityaSripal AdityaSripal mentioned this issue Jul 14, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega moved this to In progress in ibc-go Jul 14, 2022
@crodriguezvega crodriguezvega moved this from In progress to In review in ibc-go Jul 22, 2022
@mergify mergify bot closed this as completed in #1703 Oct 6, 2022
mergify bot pushed a commit that referenced this issue Oct 6, 2022
@AdityaSripal
Simplify SendPacket API (#1703)
88525d2 
## Description



closes: #1395 

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [ ] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes
Repository owner moved this from In review to Done in ibc-go Oct 6, 2022
mergify bot pushed a commit that referenced this issue Oct 6, 2022
@AdityaSripal @mergify
Simplify SendPacket API (#1703)
ec3b725 
## Description

closes: #1395

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [ ] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes

(cherry picked from commit 88525d2)

# Conflicts:
#	modules/apps/29-fee/keeper/keeper.go
#	modules/core/04-channel/keeper/packet.go
#	modules/core/04-channel/keeper/packet_test.go
colin-axner added a commit that referenced this issue Oct 11, 2022
@mergify @AdityaSripal
@crodriguezvega @colin-axner
Simplify SendPacket API (backport #1703) (#2482)
3dd5a93 
* Simplify SendPacket API (#1703)

## Description

closes: #1395

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [ ] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes

(cherry picked from commit 88525d2)

# Conflicts:
#	modules/apps/29-fee/keeper/keeper.go
#	modules/core/04-channel/keeper/packet.go
#	modules/core/04-channel/keeper/packet_test.go

* fix conflicts

* Update develop.md

* remove test that was added for 02-client refactor (and therefore before v6.0.x was branched off)

Co-authored-by: Aditya <[email protected]>
Co-authored-by: crodriguezvega <[email protected]>
Co-authored-by: Carlos Rodriguez <[email protected]>
Co-authored-by: colin axnér <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdityaSripal AdityaSripal

Labels
None yet
Projects
ibc-go
Archived in project
Milestone
v6.0.0
Development

Successfully merging a pull request may close this issue.

Simplify SendPacket API cosmos/ibc-go
3 participants
@crodriguezvega @AdityaSripal @colin-axner