Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the proto module on BSR #1345

Closed
3 tasks
mzabaluev opened this issue May 9, 2022 · 3 comments · Fixed by crypto-org-chain/chain-main#860
Closed
3 tasks

Publish the proto module on BSR #1345

mzabaluev opened this issue May 9, 2022 · 3 comments · Fixed by crypto-org-chain/chain-main#860

Comments

@mzabaluev
Copy link

mzabaluev commented May 9, 2022

Summary

Publish the ibc proto module on Buf Schema Registry.

Problem Definition

Application developers wishing to use buf to manage the protobuf definitions and their dependencies would benefit from the IBC protobuf files being published on BSR as a module. Case in point: informalsystems/hermes#2199.
As the repository has already been equipped with buf manifests allowing code to be built from the ibc-go repository as an input, it would seem like a logical progression to fully convert the proto files to a module.

Proposal

Replace third_party/proto files with dependencies managed via the buf.yaml file. To generate Go code, define buf.gen.yaml and specify proper use of protoc plugins rather than the current transitional solution invoking buf protoc.
Once the adaptation is done and passes the required lints, push the module to BSR as https://buf.build/cosmos/ibc.

This may need some work on behalf of tendermint, as those proto files are not currently in BSR either, and we don't want to diamond them via cosmos-sdk and ibc-go.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner
Copy link
Contributor

I believe this is the same proposal as #808?

In favor of adding our proto files to the buf schema registry 👍

@mzabaluev
Copy link
Author

I believe this is the same proposal as #808?

That seems to concern with a particular .proto file, it does not specifically say "make everything properly buf without vendored proto files and push to BSR".

@crodriguezvega crodriguezvega moved this to Backlog in ibc-go May 10, 2022
tomtau pushed a commit to crypto-org-chain/chain-main that referenced this issue Sep 23, 2022
Solution: Add nft-transfer module.

Note: Have to include ibc-go git submodule for building protobuf files. Can be removed once this issue is closed: cosmos/ibc-go#1345
devashishdxt added a commit to devashishdxt/chain-main that referenced this issue Sep 23, 2022
Solution: Add nft-transfer module.

Note: Have to include ibc-go git submodule for building protobuf files. Can be removed once this issue is closed: cosmos/ibc-go#1345
tomtau pushed a commit to crypto-org-chain/chain-main that referenced this issue Sep 23, 2022
Solution: Add nft-transfer module.

Note: Have to include ibc-go git submodule for building protobuf files. Can be removed once this issue is closed: cosmos/ibc-go#1345
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Nov 1, 2022
@damiannolan
Copy link
Member

closed by #2705

Repository owner moved this from Backlog to Todo in ibc-go Nov 9, 2022
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

3 participants