Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ParseKeyCounterpartyRelayer function #1000

Closed
3 tasks
colin-axner opened this issue Feb 24, 2022 · 3 comments
Closed
3 tasks

Add ParseKeyCounterpartyRelayer function #1000

colin-axner opened this issue Feb 24, 2022 · 3 comments
Assignees
@charleenfei
Labels
29-fee good first issue Good for newcomers
Milestone
Fee middleware alpha

Comments

@colin-axner
Copy link
Contributor

Summary

Same as #998 except for KeyCounterpartyRelayer (return address and channelID)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added good first issue Good for newcomers 29-fee labels Feb 24, 2022
@colin-axner colin-axner changed the title Add ParseKeyCounterpartyRelayer Add ParseKeyCounterpartyRelayer function Feb 24, 2022
@seantking seantking self-assigned this Feb 25, 2022
@crodriguezvega crodriguezvega moved this to In progress in ibc-go Feb 28, 2022
@crodriguezvega crodriguezvega added this to the Fee Middleware milestone Feb 28, 2022
@charleenfei charleenfei assigned charleenfei and unassigned seantking Mar 2, 2022
@charleenfei
Copy link
Contributor

the getter function GetCounterpartyAddress doesn't do any parsing.

@colin-axner
Copy link
Contributor Author

It does here

@charleenfei charleenfei mentioned this issue Mar 2, 2022
Merged
9 tasks
@charleenfei charleenfei moved this from In progress to In review in ibc-go Mar 2, 2022
@colin-axner
Copy link
Contributor Author

closed!

Repository owner moved this from In review to Done in ibc-go Mar 3, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@gupadhyaya
move proxyApp.VerifyFraudProofSync to ProofService (cosmos#1000)
4c951e4 
Fixes cosmos#982

---------

Co-authored-by: Ganesha Upadhyaya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charleenfei charleenfei

Labels
29-fee good first issue Good for newcomers
Projects
ibc-go
Archived in project
Milestone
Fee middleware alpha
Development

No branches or pull requests
4 participants
@crodriguezvega @seantking @charleenfei @colin-axner