fix: updating port-id & fixing OnChanOpenInit bug (#321)

* fix: updating port-id & fixing OnChanOpenInit bug * Update modules/apps/27-interchain-accounts/keeper/handshake.go Co-authored-by: colin axnér <[email protected]>
cosmos · Aug 9, 2021 · 881276f · 881276f
1 parent 38ebbff
commit 881276f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/modules/apps/27-interchain-accounts/keeper/handshake.go b/modules/apps/27-interchain-accounts/keeper/handshake.go
@@ -39,9 +39,10 @@ func (k Keeper) OnChanOpenInit(
 	if version != types.Version {
 		return sdkerrors.Wrapf(channeltypes.ErrInvalidChannelVersion, "channel version must be '%s' (%s != %s)", types.Version, version, types.Version)
 	}
-	channelID, found := k.GetActiveChannel(ctx, portID)
+
+	existingChannelID, found := k.GetActiveChannel(ctx, portID)
 	if found {
-		return sdkerrors.Wrapf(porttypes.ErrInvalidPort, "existing active channel (%s) for portID (%s)", channelID, portID)
+		return sdkerrors.Wrapf(porttypes.ErrInvalidPort, "existing active channel (%s) for portID (%s)", existingChannelID, portID)
 	}
 
 	// Claim channel capability passed back by IBC module

diff --git a/modules/apps/27-interchain-accounts/types/keys.go b/modules/apps/27-interchain-accounts/types/keys.go
@@ -10,7 +10,7 @@ const (
 	// module supports
 	Version = "ics27-1"
 
-	PortID = "interchain-account"
+	PortID = "ibcaccount"
 
 	StoreKey  = ModuleName
 	RouterKey = ModuleName