Skip to content

Commit

Permalink
Update v4-to-v5.md
Browse files Browse the repository at this point in the history
  • Loading branch information
Carlos Rodriguez authored Sep 27, 2022
1 parent 1313dc9 commit 833f578
Showing 1 changed file with 17 additions and 19 deletions.
36 changes: 17 additions & 19 deletions docs/migrations/v4-to-v5.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,25 +38,6 @@ The `AnteDecorator` was actually renamed twice, but in [this PR](https://github.

## IBC Apps

### ICS27 - Interchain Accounts

An additional parameter, `ics4Wrapper` has been added to the `host` submodule `NewKeeper` function in `modules/apps/27-interchain-accounts/host/keeper`.
This allows the `host` submodule to correctly unwrap the channel version for channel reopening handshakes in the `OnChanOpenTry` callback.

```diff
func NewKeeper(
cdc codec.BinaryCodec,
key storetypes.StoreKey,
paramSpace paramtypes.Subspace,
+ ics4Wrapper icatypes.ICS4Wrapper,
channelKeeper icatypes.ChannelKeeper,
portKeeper icatypes.PortKeeper,
accountKeeper icatypes.AccountKeeper,
scopedKeeper icatypes.ScopedKeeper,
msgRouter icatypes.MessageRouter,
) Keeper
```

### Core

The `key` parameter of the `NewKeeper` function in `modules/core/keeper` is now of type `storetypes.StoreKey` (where `storetypes` is an import alias for `"github.com/cosmos/cosmos-sdk/store/types"`):
Expand Down Expand Up @@ -198,6 +179,23 @@ type MessageRouter interface {

The `RegisterRESTRoutes` function in `modules/apps/27-interchain-accounts` has been removed.

An additional parameter, `ics4Wrapper` has been added to the `host` submodule `NewKeeper` function in `modules/apps/27-interchain-accounts/host/keeper`.
This allows the `host` submodule to correctly unwrap the channel version for channel reopening handshakes in the `OnChanOpenTry` callback.

```diff
func NewKeeper(
cdc codec.BinaryCodec,
key storetypes.StoreKey,
paramSpace paramtypes.Subspace,
+ ics4Wrapper icatypes.ICS4Wrapper,
channelKeeper icatypes.ChannelKeeper,
portKeeper icatypes.PortKeeper,
accountKeeper icatypes.AccountKeeper,
scopedKeeper icatypes.ScopedKeeper,
msgRouter icatypes.MessageRouter,
) Keeper
```

#### Cosmos SDK message handler responses in packet acknowledgement

The construction of the transaction response of a message execution on the host chain has changed. The `Data` field in the `sdk.TxMsgData` has been deprecated and since Cosmos SDK 0.46 the `MsgResponses` field contains the message handler responses packed into `Any`s.
Expand Down

0 comments on commit 833f578

Please sign in to comment.