Skip to content

Commit

Permalink
remove connection and channel handshake cli commands (#109)
Browse files Browse the repository at this point in the history
* remove connection handshake cli commands

* add changelog entry

* remove channel handshake commands

* update gomod
  • Loading branch information
colin-axner authored Apr 12, 2021
1 parent e988386 commit 4e145d8
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 678 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,9 @@ Ref: https://keepachangelog.com/en/1.0.0/

## [Unreleased]

### API Breaking
### API Breaking

* (modules/core) [\#109](https://github.com/cosmos/ibc-go/pull/109) Remove connection and channel handshake CLI commands.
* (modules) [\#107](https://github.com/cosmos/ibc-go/pull/107) Modify OnRecvPacket callback to return an acknowledgement which indicates if it is successful or not. Callback state changes are discarded for unsuccessful acknowledgements only.
* (modules) [\#108](https://github.com/cosmos/ibc-go/pull/108) All message constructors take the signer as a string to prevent upstream bugs. The `String()` function for an SDK Acc Address relies on external context.

Expand Down
1 change: 0 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ require (
github.com/rakyll/statik v0.1.7
github.com/spf13/cast v1.3.1
github.com/spf13/cobra v1.1.3
github.com/spf13/pflag v1.0.5
github.com/spf13/viper v1.7.1
github.com/stretchr/testify v1.7.0
github.com/tendermint/tendermint v0.34.8
Expand Down
21 changes: 0 additions & 21 deletions modules/core/03-connection/client/cli/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package cli
import (
"github.com/spf13/cobra"

"github.com/cosmos/cosmos-sdk/client"
"github.com/cosmos/ibc-go/modules/core/03-connection/types"
)

Expand All @@ -24,23 +23,3 @@ func GetQueryCmd() *cobra.Command {

return queryCmd
}

// NewTxCmd returns a CLI command handler for all x/ibc connection transaction commands.
func NewTxCmd() *cobra.Command {
txCmd := &cobra.Command{
Use: types.SubModuleName,
Short: "IBC connection transaction subcommands",
DisableFlagParsing: true,
SuggestionsMinimumDistance: 2,
RunE: client.ValidateCmd,
}

txCmd.AddCommand(
NewConnectionOpenInitCmd(),
NewConnectionOpenTryCmd(),
NewConnectionOpenAckCmd(),
NewConnectionOpenConfirmCmd(),
)

return txCmd
}
348 changes: 0 additions & 348 deletions modules/core/03-connection/client/cli/tx.go

This file was deleted.

Loading

0 comments on commit 4e145d8

Please sign in to comment.