Skip to content

Commit

Permalink
removed unused variables (#2692)
Browse files Browse the repository at this point in the history
## Description



closes: #2486 

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules/10-structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [x] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [x] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [x] Re-reviewed `Files changed` in the Github PR explorer
- [ ] Review `Codecov Report` in the comment section below once CI passes
  • Loading branch information
Daniyal98 authored Nov 8, 2022
1 parent f02f9d1 commit 4d19c16
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
3 changes: 2 additions & 1 deletion modules/core/04-channel/keeper/handshake_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,8 @@ func (suite *KeeperTestSuite) TestChanCloseInit() {
// create channel in init
path.SetChannelOrdered()
err = path.EndpointA.ChanOpenInit()

suite.Require().NoError(err)

// ensure channel capability check passes
suite.chainA.CreateChannelCapability(suite.chainA.GetSimApp().ScopedIBCMockKeeper, path.EndpointA.ChannelConfig.PortID, path.EndpointA.ChannelID)
channelCap = suite.chainA.GetChannelCapability(path.EndpointA.ChannelConfig.PortID, path.EndpointA.ChannelID)
Expand Down
9 changes: 2 additions & 7 deletions modules/core/04-channel/keeper/packet_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,8 @@ var (
defaultTimeoutHeight = clienttypes.NewHeight(1, 100)

// for when the testing package cannot be used
clientIDA = "clientA"
clientIDB = "clientB"
connIDA = "connA"
connIDB = "connB"
portID = "portid"
channelIDA = "channelidA"
channelIDB = "channelidB"
connIDA = "connA"
connIDB = "connB"
)

// TestSendPacket tests SendPacket from chainA to chainB
Expand Down

0 comments on commit 4d19c16

Please sign in to comment.