Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PFM to not fail packets that aren't FungibleTokenPacketData #105

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

assafmo
Copy link
Contributor

@assafmo assafmo commented Sep 28, 2023

Currently, PFM fails packets that are not FungibleTokenPacketData. This means that PFM cannot support IBC apps that don't exclusively use FungibleTokenPacketData as the payload format (i.e., ics20-* or the transfer app). Therefore, CosmWasm cannot have PFM in its IBC stack, even though CosmWasm contracts may implement the ics20-* protocol (e.g., cw20-ics20: https://github.com/CosmWasm/cw-plus/tree/HEAD/contracts/cw20-ics20).

This commit fixes the issue by passing the packet forward in the stack rather than failing packets that are not FungibleTokenPacketData.

This will allow PFM to support a wider range of IBC apps and will make it possible for CosmWasm to have PFM in its IBC stack, which will improve the interoperability and usability of PFM in the Cosmos ecosystem

@assafmo assafmo force-pushed the pfm-dont-fail-non-ics20-packets branch from c32ab22 to 4165527 Compare September 28, 2023 05:58
Currently, PFM fails packets that are not FungibleTokenPacketData. This means that PFM cannot support IBC apps that don't exclusively use FungibleTokenPacketData as the payload format (i.e. ics20-* or the transfer app). Therefore, CosmWasm cannot have PFM in its IBC stack, even though CosmWasm contracts may implement ics20-* (e.g. cw20-ics20: https://github.com/CosmWasm/cw-plus/tree/HEAD/contracts/cw20-ics20).

This commit fixes the issue by passing the packet forward in the stack rather than failing packets that are not FungibleTokenPacketData.

This will allow PFM to support a wider range of IBC apps and will make it possible for CosmWasm to have PFM in its IBC stack, which will improve the interoperability and usability of PFM in the Cosmos ecosystem
@assafmo assafmo force-pushed the pfm-dont-fail-non-ics20-packets branch from 4165527 to 8eed61d Compare September 28, 2023 06:10
@agouin agouin added the BACKPORT Backport into maintained branches label Sep 28, 2023
@jtieri jtieri merged commit 39de938 into cosmos:main Sep 28, 2023
5 checks passed
mergify bot pushed a commit that referenced this pull request Sep 28, 2023
Currently, PFM fails packets that are not FungibleTokenPacketData. This means that PFM cannot support IBC apps that don't exclusively use FungibleTokenPacketData as the payload format (i.e. ics20-* or the transfer app). Therefore, CosmWasm cannot have PFM in its IBC stack, even though CosmWasm contracts may implement ics20-* (e.g. cw20-ics20: https://github.com/CosmWasm/cw-plus/tree/HEAD/contracts/cw20-ics20).

This commit fixes the issue by passing the packet forward in the stack rather than failing packets that are not FungibleTokenPacketData.

This will allow PFM to support a wider range of IBC apps and will make it possible for CosmWasm to have PFM in its IBC stack, which will improve the interoperability and usability of PFM in the Cosmos ecosystem

(cherry picked from commit 39de938)
mergify bot pushed a commit that referenced this pull request Sep 28, 2023
Currently, PFM fails packets that are not FungibleTokenPacketData. This means that PFM cannot support IBC apps that don't exclusively use FungibleTokenPacketData as the payload format (i.e. ics20-* or the transfer app). Therefore, CosmWasm cannot have PFM in its IBC stack, even though CosmWasm contracts may implement ics20-* (e.g. cw20-ics20: https://github.com/CosmWasm/cw-plus/tree/HEAD/contracts/cw20-ics20).

This commit fixes the issue by passing the packet forward in the stack rather than failing packets that are not FungibleTokenPacketData.

This will allow PFM to support a wider range of IBC apps and will make it possible for CosmWasm to have PFM in its IBC stack, which will improve the interoperability and usability of PFM in the Cosmos ecosystem

(cherry picked from commit 39de938)
mergify bot pushed a commit that referenced this pull request Sep 28, 2023
Currently, PFM fails packets that are not FungibleTokenPacketData. This means that PFM cannot support IBC apps that don't exclusively use FungibleTokenPacketData as the payload format (i.e. ics20-* or the transfer app). Therefore, CosmWasm cannot have PFM in its IBC stack, even though CosmWasm contracts may implement ics20-* (e.g. cw20-ics20: https://github.com/CosmWasm/cw-plus/tree/HEAD/contracts/cw20-ics20).

This commit fixes the issue by passing the packet forward in the stack rather than failing packets that are not FungibleTokenPacketData.

This will allow PFM to support a wider range of IBC apps and will make it possible for CosmWasm to have PFM in its IBC stack, which will improve the interoperability and usability of PFM in the Cosmos ecosystem

(cherry picked from commit 39de938)
jtieri pushed a commit that referenced this pull request Sep 28, 2023
#107)

Currently, PFM fails packets that are not FungibleTokenPacketData. This means that PFM cannot support IBC apps that don't exclusively use FungibleTokenPacketData as the payload format (i.e. ics20-* or the transfer app). Therefore, CosmWasm cannot have PFM in its IBC stack, even though CosmWasm contracts may implement ics20-* (e.g. cw20-ics20: https://github.com/CosmWasm/cw-plus/tree/HEAD/contracts/cw20-ics20).

This commit fixes the issue by passing the packet forward in the stack rather than failing packets that are not FungibleTokenPacketData.

This will allow PFM to support a wider range of IBC apps and will make it possible for CosmWasm to have PFM in its IBC stack, which will improve the interoperability and usability of PFM in the Cosmos ecosystem

(cherry picked from commit 39de938)

Co-authored-by: Assaf Morami <[email protected]>
jtieri pushed a commit that referenced this pull request Sep 28, 2023
#106)

Currently, PFM fails packets that are not FungibleTokenPacketData. This means that PFM cannot support IBC apps that don't exclusively use FungibleTokenPacketData as the payload format (i.e. ics20-* or the transfer app). Therefore, CosmWasm cannot have PFM in its IBC stack, even though CosmWasm contracts may implement ics20-* (e.g. cw20-ics20: https://github.com/CosmWasm/cw-plus/tree/HEAD/contracts/cw20-ics20).

This commit fixes the issue by passing the packet forward in the stack rather than failing packets that are not FungibleTokenPacketData.

This will allow PFM to support a wider range of IBC apps and will make it possible for CosmWasm to have PFM in its IBC stack, which will improve the interoperability and usability of PFM in the Cosmos ecosystem

(cherry picked from commit 39de938)

Co-authored-by: Assaf Morami <[email protected]>
jtieri pushed a commit that referenced this pull request Sep 28, 2023
#108)

Currently, PFM fails packets that are not FungibleTokenPacketData. This means that PFM cannot support IBC apps that don't exclusively use FungibleTokenPacketData as the payload format (i.e. ics20-* or the transfer app). Therefore, CosmWasm cannot have PFM in its IBC stack, even though CosmWasm contracts may implement ics20-* (e.g. cw20-ics20: https://github.com/CosmWasm/cw-plus/tree/HEAD/contracts/cw20-ics20).

This commit fixes the issue by passing the packet forward in the stack rather than failing packets that are not FungibleTokenPacketData.

This will allow PFM to support a wider range of IBC apps and will make it possible for CosmWasm to have PFM in its IBC stack, which will improve the interoperability and usability of PFM in the Cosmos ecosystem

(cherry picked from commit 39de938)

Co-authored-by: Assaf Morami <[email protected]>
assafmo added a commit to scrtlabs/SecretNetwork that referenced this pull request Oct 4, 2023
nicolaslara added a commit to osmosis-labs/osmosis that referenced this pull request Oct 23, 2023
nicolaslara added a commit to osmosis-labs/osmosis that referenced this pull request Oct 23, 2023
ValarDragon pushed a commit to osmosis-labs/osmosis that referenced this pull request Oct 23, 2023
* use a version of pfm that inclides cosmos/ibc-apps#105

* lint
PaddyMc pushed a commit to osmosis-labs/osmosis that referenced this pull request Oct 23, 2023
* use a version of pfm that inclides cosmos/ibc-apps#105

* lint
PaddyMc pushed a commit to osmosis-labs/osmosis that referenced this pull request Oct 23, 2023
* use a version of pfm that inclides cosmos/ibc-apps#105

* lint
ValarDragon pushed a commit to osmosis-labs/osmosis that referenced this pull request Oct 23, 2023
* use a version of pfm that inclides cosmos/ibc-apps#105

* lint
@cosmos cosmos deleted a comment from mergify bot Oct 23, 2023
PaddyMc added a commit to osmosis-labs/osmosis that referenced this pull request Nov 3, 2023
* Fix bad PFM error (#6734)

* use a version of pfm that inclides cosmos/ibc-apps#105

* lint

* chore: add changelog

---------

Co-authored-by: Nicolas Lara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BACKPORT Backport into maintained branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants