feat: make ChangeSet and KVPair protobuf serializable #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
reviewed
Apr 8, 2023
There was a problem hiding this comment.
dam i guess we need the proto type, @cool-develope does this help you as well?
Implement protobuf messages, and setup buf.build ``` $ buf generate proto ```
yihuang
changed the title
tac0turtle
approved these changes
Apr 10, 2023
yihuang
added a commit
to yihuang/iavl
that referenced
this pull request
Apr 10, 2023
Implement protobuf messages, and setup buf.build ``` $ buf generate proto ```
|
@Mergifyio backport release/v0.20.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 10, 2023
(cherry picked from commit 61be28a) # Conflicts: # CHANGELOG.md # diff.go # diff_test.go # nodedb.go
|
@Mergifyio backport release/v1.x.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 10, 2023
(cherry picked from commit 61be28a) # Conflicts: # CHANGELOG.md
yihuang
added a commit
that referenced
this pull request
Apr 10, 2023
tac0turtle
pushed a commit
that referenced
this pull request
Apr 11, 2023
…#734) Co-authored-by: yihuang <[email protected]>
tac0turtle
pushed a commit
that referenced
this pull request
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement protobuf messages, and setup buf.build
Context
we are reusing the
ChangeSetandKVPairtype from the iavl library, and we need it to be serializable, so instead of rolling our own types for it, it's be better if the iavl type support protobuf serialization directly.