Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add nodeKey integer field #593

Merged
merged 2 commits into from
Oct 19, 2022
Merged

feat: add nodeKey integer field #593

merged 2 commits into from
Oct 19, 2022

Conversation

cool-develope
Copy link
Collaborator

@cool-develope cool-develope commented Oct 18, 2022 •
edited
Loading

ref: #592
ref: #137

@cool-develope cool-develope requested a review from a team as a code owner October 18, 2022 12:10
@cool-develope cool-develope marked this pull request as draft October 18, 2022 12:12
@cool-develope cool-develope marked this pull request as ready for review October 18, 2022 13:33
tac0turtle
tac0turtle approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cool-develope
Copy link
Collaborator Author

utACK

I think the tests are already covered by the original tests because we are triggering errors when decode and encode the node.

@tac0turtle
Copy link
Member

sorry, meant I didnt pull and test it.

@cool-develope cool-develope merged commit 7204160 into 592/nonce-key Oct 19, 2022
@cool-develope cool-develope deleted the 592/subtask-1 branch October 19, 2022 12:58
@cool-develope cool-develope mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@colin-axner colin-axner Awaiting requested review from colin-axner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cool-develope @tac0turtle