Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change key format for node #568

Closed
wants to merge 16 commits into from
Closed

feat: change key format for node #568

wants to merge 16 commits into from

Conversation

catShaark
Copy link
Contributor

No description provided.

@catShaark catShaark changed the title add path to node change key format for node Sep 21, 2022
@catShaark catShaark closed this Sep 21, 2022
@catShaark catShaark reopened this Sep 21, 2022
@yihuang
Copy link
Collaborator

yihuang commented Sep 26, 2022

The change looks awsome, Is there a migration strategy to migrate production db gradually?

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 4, 2022

This pull request introduces 2 alerts when merging 5924e7e into 9cf5d7a - view on LGTM.com

new alerts:

  • 2 for Missing error check

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 5, 2022

This pull request introduces 2 alerts when merging 99aeb4b into ae4aeee - view on LGTM.com

new alerts:

  • 2 for Missing error check

@catShaark
Copy link
Contributor Author

The change looks awsome, Is there a migration strategy to migrate production db gradually?

I don't know yet, I'll look into it after fixing all the tests

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 5, 2022

This pull request introduces 2 alerts when merging 33ceaf3 into ae4aeee - view on LGTM.com

new alerts:

  • 2 for Missing error check

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 6, 2022

This pull request introduces 2 alerts when merging ca2ac94 into 797c8a9 - view on LGTM.com

new alerts:

  • 2 for Missing error check

faddat
faddat reviewed Oct 6, 2022
View reviewed changes
node.go Outdated
}

var _ cache.Node = (*Node)(nil)

var dmm = []byte{226, 95, 219, 92, 42, 16, 81, 37, 50, 22, 7, 121, 82, 211, 57, 104, 2, 130, 61, 76, 80, 124, 97, 236, 13, 231, 44, 35, 206, 183, 207, 214}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's for debugging, I'll remove it

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Oct 6, 2022

This pull request introduces 2 alerts when merging 68ebd97 into 797c8a9 - view on LGTM.com

new alerts:

  • 2 for Missing error check

@catShaark catShaark changed the title change key format for node feat: change key format for node Oct 8, 2022
@tac0turtle
Copy link
Member

closing this

@tac0turtle tac0turtle closed this Jan 2, 2023
@tac0turtle
Copy link
Member

closing this

@elias-orijtech elias-orijtech mentioned this pull request May 12, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faddat faddat faddat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@catShaark @yihuang @tac0turtle @faddat